[stable21] Add UI feedback when local participant is not connected #5797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
added
bug
feature: call 📹
backportbot-nextcloud
bot
requested review from
PVince81,
danxuliu,
marcoambrosini and
nickvergessen
Member
|
Let's wait until we tested it on our instance |
nickvergessen
changed the title
When the MCU is used there will be a sender peer connection (the so called "own peer"). The ICE connection state of that peer connection is now exposed in LocalCallParticipantModel in the same way as in CallParticipantModel. However, unlike the CallParticipantModel, the LocalCallParticipantModel is always set and the peer object set or unset on it as needed; if there is no peer object set the connection state will not be set. When the MCU is not used there is no sender peer connection (nor any other peer associated to the LocalCallParticipantModel), so in that case the connection state attribute will not be set either. Besides that some logs were also added for the ICE connection state changes of the own peer, similar to the logs already present for the peer connection of the other participants. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
This will be needed to show a loading icon on the wrapper, as it is not possible to show it directly on the video. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When the connection with other participants is lost those participants are shown dimmed and with a loading spinner. However, when the MCU is used that only covers receiving audio and video from those participants. Other participants can not hear or see the local participant until the sender peer object has connected. Therefore now the local video / avatar is dimmed and shows a loading spinner like done with the remote participants when the sender peer object is not connected. Note that when the MCU is used the sender participant will always reconnect, so there is no separate "isLoading" property like the one used for remote participants (which, moreover, is needed only when the MCU is not used). When the MCU is not used the connections are peer to peer between partipants, so the already existing dimming and loading spinner on the remote participants views already show whether those participants can hear and see the local participant or not. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
force-pushed
the
backport/5779/stable21.1
branch
from
60567ec to
1c20294
Compare
danxuliu
approved these changes
Jul 2, 2021
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Tested and works 👍
I have rebased it on stable21 and fixed the conflicts so it is ready to merge once it has been tested in our instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5779