Skip to content

Fix asterix conflict with notifications #5831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Jun 21, 2021
Merged

Fix asterix conflict with notifications #5831

nickvergessen merged 1 commit into from
Jun 21, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 21, 2021 •
edited
Loading

Reverse of nextcloud/notifications#1028

Steps

  1. Reload page on talk and wait until it finished loading
  2. Open a new tab so the page is in the background
  3. Trigger a notification: occ notification:generate
  4. Write a message in a channel where this user is a member of

Before

* * …

After

* …

@nickvergessen nickvergessen added this to the 💙 Next Major (22) milestone Jun 21, 2021
@nickvergessen nickvergessen mentioned this pull request Jun 21, 2021
Merged
PVince81
PVince81 approved these changes Jun 21, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nickvergessen nickvergessen merged commit d381137 into master Jun 21, 2021
@nickvergessen nickvergessen deleted the bugfix/noid/fix-asterix-conflict-with-notifications branch June 21, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@revpriest revpriest Awaiting requested review from revpriest

Assignees

No one assigned

Labels

3. to review bug feature: chat 💬 Chat and system messages

Projects

None yet

Milestone

v12.0.0-rc.1

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen @PVince81