Add logs for connection quality warning #5884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
added
3. to review
feature: frontend 🖌️
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Any command or something that can be done to force it for testing? 😅
Member
Author
Other than that... I test all this with a virtual machine changing the network interface properties with netem 🤷 |
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
The logs are printed when the PeerConnectionAnalyzer changes to a state that causes a connection quality warning to be shown (very bad quality or not transmitted data). Currently the connection quality is analyzed only when the HPB is used and only for the sender participant, so there will be at most a single PeerConnectionAnalyzer. Due to this, for simplicity, for now the stats are logged without any participant identifier. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
nickvergessen
force-pushed
the
add-logs-for-connection-quality-warning
branch
from
0726aba to
37aa5f3
Compare
Member
|
/backport to stable22 |
Member
Author
|
/backport to stable21 |
|
The backport to stable21 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5362
The logs are printed when the PeerConnectionAnalyzer changes to a state that causes a connection quality warning to be shown (very bad quality or not transmitted data).
Currently the connection quality is analyzed only when the HPB is used and only for the sender participant, so there will be at most a single PeerConnectionAnalyzer. Due to this, for simplicity, for now the stats are logged without any participant identifier.