Skip to content

Fix connection quality warning shown due to stalled stats #5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 5 commits into from
Jul 1, 2021
Merged

Fix connection quality warning shown due to stalled stats #5885

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9205185
Fix stats being reset when enabling the analysis twice
danxuliu Jun 24, 2021
ecb4a26
Convert "_connectionQuality" attribute to an array
danxuliu Jun 25, 2021
b196b8d
Get attributes based on kind instead of explictly pass them
danxuliu Jun 25, 2021
dc4d2c4
Extract adding the processed stats to its own method
danxuliu Jun 25, 2021
aadfd0e
Fix very bad quality reported due to stalled stats
danxuliu Jun 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Extract adding the processed stats to its own method 
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
  • Loading branch information
@danxuliu
danxuliu committed Jun 30, 2021
commit dc4d2c4ca35e69496ead2c16a622bb46a972caed
98 changes: 36 additions & 62 deletions src/utils/webrtc/analyzers/PeerConnectionAnalyzer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,39 +399,7 @@ PeerConnectionAnalyzer.prototype = {
packetsLost[kind] = this._packetsLost[kind].getLastRawValue()
}

if (packets[kind] >= 0) {
this._packets[kind].add(packets[kind])
}
if (packetsLost[kind] >= 0) {
this._packetsLost[kind].add(packetsLost[kind])
}
if (packets[kind] >= 0 && packetsLost[kind] >= 0) {
// The packet stats are cumulative values, so the isolated
// values are got from the helper object.
// If there were no transmitted packets in the last stats the
// ratio is higher than 1 both to signal that and to force the
// quality towards a very bad quality faster, but not
// immediately.
let packetsLostRatio = 1.5
if (this._packets[kind].getLastRelativeValue() > 0) {
packetsLostRatio = this._packetsLost[kind].getLastRelativeValue() / this._packets[kind].getLastRelativeValue()
}
this._packetsLostRatio[kind].add(packetsLostRatio)
}
if (timestamp[kind] >= 0) {
this._timestamps[kind].add(timestamp[kind])
this._timestampsForLogs[kind].add(timestamp[kind])
}
if (packets[kind] >= 0 && timestamp[kind] >= 0) {
const elapsedSeconds = this._timestamps[kind].getLastRelativeValue() / 1000
// The packet stats are cumulative values, so the isolated
// values are got from the helper object.
const packetsPerSecond = this._packets[kind].getLastRelativeValue() / elapsedSeconds
this._packetsPerSecond[kind].add(packetsPerSecond)
}
if (roundTripTime[kind] >= 0) {
this._roundTripTime[kind].add(roundTripTime[kind])
}
this._addStats(kind, packets[kind], packetsLost[kind], timestamp[kind], roundTripTime[kind])
}
},

Expand Down Expand Up @@ -490,36 +458,42 @@ PeerConnectionAnalyzer.prototype = {
packetsLost[kind] = this._packetsLost[kind].getLastRawValue()
}

if (packets[kind] >= 0) {
this._packets[kind].add(packets[kind])
}
if (packetsLost[kind] >= 0) {
this._packetsLost[kind].add(packetsLost[kind])
}
if (packets[kind] >= 0 && packetsLost[kind] >= 0) {
// The packet stats are cumulative values, so the isolated
// values are got from the helper object.
// If there were no transmitted packets in the last stats the
// ratio is higher than 1 both to signal that and to force the
// quality towards a very bad quality faster, but not
// immediately.
let packetsLostRatio = 1.5
if (this._packets[kind].getLastRelativeValue() > 0) {
packetsLostRatio = this._packetsLost[kind].getLastRelativeValue() / this._packets[kind].getLastRelativeValue()
}
this._packetsLostRatio[kind].add(packetsLostRatio)
}
if (timestamp[kind] >= 0) {
this._timestamps[kind].add(timestamp[kind])
this._timestampsForLogs[kind].add(timestamp[kind])
}
if (packets[kind] >= 0 && timestamp[kind] >= 0) {
const elapsedSeconds = this._timestamps[kind].getLastRelativeValue() / 1000
// The packet stats are cumulative values, so the isolated
// values are got from the helper object.
const packetsPerSecond = this._packets[kind].getLastRelativeValue() / elapsedSeconds
this._packetsPerSecond[kind].add(packetsPerSecond)
this._addStats(kind, packets[kind], packetsLost[kind], timestamp[kind])
}
},

_addStats(kind, packets, packetsLost, timestamp, roundTripTime) {
if (packets >= 0) {
this._packets[kind].add(packets)
}
if (packetsLost >= 0) {
this._packetsLost[kind].add(packetsLost)
}
if (packets >= 0 && packetsLost >= 0) {
// The packet stats are cumulative values, so the isolated values
// are got from the helper object.
// If there were no transmitted packets in the last stats the ratio
// is higher than 1 both to signal that and to force the quality
// towards a very bad quality faster, but not immediately.
let packetsLostRatio = 1.5
if (this._packets[kind].getLastRelativeValue() > 0) {
packetsLostRatio = this._packetsLost[kind].getLastRelativeValue() / this._packets[kind].getLastRelativeValue()
}
this._packetsLostRatio[kind].add(packetsLostRatio)
}
if (timestamp >= 0) {
this._timestamps[kind].add(timestamp)
this._timestampsForLogs[kind].add(timestamp)
}
if (packets >= 0 && timestamp >= 0) {
const elapsedSeconds = this._timestamps[kind].getLastRelativeValue() / 1000
// The packet stats are cumulative values, so the isolated
// values are got from the helper object.
const packetsPerSecond = this._packets[kind].getLastRelativeValue() / elapsedSeconds
this._packetsPerSecond[kind].add(packetsPerSecond)
}
if (roundTripTime !== undefined && roundTripTime >= 0) {
this._roundTripTime[kind].add(roundTripTime)
}
},

Expand Down