Skip to content

Conversation

@jimlinntu
Copy link
Contributor

@jimlinntu jimlinntu commented Jul 4, 2021

Resolved #5937

I am not sure if this will cause incompatible between different browsers,
but at least I tested it on Chrome it seems great!

Signed-off-by: Jim Lin [email protected]

Related information: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing

@jimlinntu
Copy link
Contributor Author

Screen.Recording.2021-07-04.at.5.32.36.PM.mov

@PVince81
Copy link
Member

PVince81 commented Jul 5, 2021

@jimlinntu 谢谢. I wasn't aware that there was an attribute isComposing. 😄

For me there was never a problem with input method and hitting enter while compositing.

I've still tested with fcitx on Linux with Chromium 91 and Firefox 89 and there was no side effect.

The PR seems fine and low-risk, merging.

@PVince81 PVince81 self-assigned this Jul 5, 2021
@PVince81
Copy link
Member

PVince81 commented Jul 5, 2021

@jimlinntu mind telling us what input method you used and on what platform, for the record ? Thanks

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 7766c9e into nextcloud:master Jul 5, 2021
@PVince81
Copy link
Member

PVince81 commented Jul 5, 2021

/backport to stable22

@PVince81
Copy link
Member

PVince81 commented Jul 5, 2021

/backport to stable21

@nickvergessen
Copy link
Member

Also needs to be copied to the vue lib, otherwise #4333 will bring it back as a regression?

@PVince81
Copy link
Member

PVince81 commented Jul 5, 2021

I'll add it to the checklist there to keep it in mind, then we can check how to put it into the lib

@jimlinntu
Copy link
Contributor Author

@jimlinntu mind telling us what input method you used and on what platform, for the record ? Thanks

I am using macOS Mojave 10.14.6

@jimlinntu
Copy link
Contributor Author

Just curious. I am currently using Nextcloud 19, is it possible to backport this version to NC19?

That will be great because I will not need to be aware that I can only press one Enter during my typing 😅

@PVince81
Copy link
Member

PVince81 commented Jul 7, 2021

@jimlinntu Nextcloud 22 just got announced yesterday and Nextcloud 19 is already end of life, and Nextcloud 20 will be end of life in October. I'd suggest you look into upgrading very soon :-)

ref: https://docs.nextcloud.com/server/latest/admin_manual/release_schedule.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Partial text is sent but not all after I press enter using an input method to compose words

3 participants