-
Notifications
You must be signed in to change notification settings - Fork 508
Prevent submitting the message when the user is composing #5939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jim Lin <[email protected]>
Screen.Recording.2021-07-04.at.5.32.36.PM.mov |
|
@jimlinntu 谢谢. I wasn't aware that there was an attribute For me there was never a problem with input method and hitting enter while compositing. I've still tested with fcitx on Linux with Chromium 91 and Firefox 89 and there was no side effect. The PR seems fine and low-risk, merging. |
|
@jimlinntu mind telling us what input method you used and on what platform, for the record ? Thanks |
PVince81
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
/backport to stable22 |
|
/backport to stable21 |
|
Also needs to be copied to the vue lib, otherwise #4333 will bring it back as a regression? |
|
I'll add it to the checklist there to keep it in mind, then we can check how to put it into the lib |
I am using macOS Mojave 10.14.6 |
|
Just curious. I am currently using Nextcloud 19, is it possible to backport this version to NC19? That will be great because I will not need to be aware that I can only press one Enter during my typing 😅 |
|
@jimlinntu Nextcloud 22 just got announced yesterday and Nextcloud 19 is already end of life, and Nextcloud 20 will be end of life in October. I'd suggest you look into upgrading very soon :-) ref: https://docs.nextcloud.com/server/latest/admin_manual/release_schedule.html |
Resolved #5937
I am not sure if this will cause incompatible between different browsers,
but at least I tested it on Chrome it seems great!
Signed-off-by: Jim Lin [email protected]
Related information: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/isComposing