Never show read marker on the very last message #5964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable22 |
PVince81
force-pushed
the
bugfix/5959/never-unread-marker-lastmessage
branch
from
ce09d04 to
e9d6d27
Compare
Member
Author
|
added test and squashed |
| isLastReadMessage() { | ||
| if (!this.nextMessageId) { | ||
| // never display indicator on the very last message | ||
| return |
Member
There was a problem hiding this comment.
Suggested change
| return | |
| return false |
nickvergessen
approved these changes
Jul 7, 2021
Added condition to detect the last message when deciding whether to render the read marker. Fixes issues when the last message is a deleted one or a command and where the marker was displayed. Signed-off-by: Vincent Petry <[email protected]> Co-authored-by: Joas Schilling <[email protected]>
PVince81
force-pushed
the
bugfix/5959/never-unread-marker-lastmessage
branch
from
e9d6d27 to
13e3999
Compare
Member
Author
|
adjusted, thanks for spotting |
Member
|
/backport to stable22.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added condition to detect the last message when deciding whether to
render the read marker.
Fixes issues when the last message is a deleted one or a command and
where the marker was displayed.
Fixes #5959