Skip to content

Conversation

@julien-nc
Copy link
Member

@julien-nc julien-nc commented Aug 26, 2021

It's done exactly like for Deck in #5110.

This can be tested with the enh/vue-rewrite branch of maps (just build with make).
The actions are added as buttons to the left click popup and as items in the right click menu.
Changes in Maps: nextcloud/maps@697931d

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, looking forward to it

@nickvergessen nickvergessen added the feature: integration 📦 Integration with 3rd party (chat) service label Sep 2, 2021
@julien-nc
Copy link
Member Author

Rebased on master, text fixed.

Works nicely, looking forward to it

One day the maps vue-rewrite branch will be merged...:grin:

@nickvergessen nickvergessen marked this pull request as draft September 14, 2021 14:11
@nickvergessen
Copy link
Member

Converting to draft until maps app is merged

@nickvergessen
Copy link
Member

Maps PR was merged.
@eneiluj will it be the 24 compatible version?

@nickvergessen
Copy link
Member

Rebased

@nickvergessen nickvergessen marked this pull request as ready for review May 2, 2022 07:27
@nickvergessen
Copy link
Member

Model of the RoomSelector.vue needs a bit of JS fixing.

It has CSS fules for modal-inner and modal-content which I think should not be the case.

#modal-inner {
width: 100%;
padding: 16px;
margin: 0 auto;
position: relative;
display: flex;
align-items: center;
justify-content: center;
h2 {
margin-bottom: 4px;
}
}
#modal-content {
position: absolute;
width: calc(100% - 40px);
height: calc(100% - 40px);
display: flex;
flex-direction: column;
}

Bildschirmfoto vom 2022-05-02 09-37-10

Otherwise it works nicely

@julien-nc
Copy link
Member Author

will it be the 24 compatible version?

@nickvergessen I don't know.

@tacruc Do you plan to make a release for 24 which includes the Vue rewrite and therefore the share action?

@nickvergessen nickvergessen merged commit bf3d6da into master May 2, 2022
@nickvergessen nickvergessen deleted the enh/maps-action branch May 2, 2022 08:27
@tacruc
Copy link

tacruc commented May 2, 2022

@eneiluj: I created an Issue with PR's, which I would like to merge, before the release, as they are small, but resolve issues.
nextcloud/maps#732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review enhancement feature: integration 📦 Integration with 3rd party (chat) service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants