-
Notifications
You must be signed in to change notification settings - Fork 508
Register 'share location' action in Maps app #6150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nickvergessen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely, looking forward to it
697f3c0 to
3f6b741
Compare
|
Rebased on master, text fixed.
One day the maps vue-rewrite branch will be merged...:grin: |
|
Converting to draft until maps app is merged |
Signed-off-by: Julien Veyssier <[email protected]>
|
Maps PR was merged. |
|
Rebased |
3f6b741 to
afc005b
Compare
|
Model of the RoomSelector.vue needs a bit of JS fixing. It has CSS fules for modal-inner and modal-content which I think should not be the case. spreed/src/views/RoomSelector.vue Lines 175 to 194 in d72d9fb
Otherwise it works nicely |
@nickvergessen I don't know. @tacruc Do you plan to make a release for 24 which includes the Vue rewrite and therefore the share action? |
|
@eneiluj: I created an Issue with PR's, which I would like to merge, before the release, as they are small, but resolve issues. |

It's done exactly like for Deck in #5110.
This can be tested with the
enh/vue-rewritebranch of maps (just build withmake).The actions are added as buttons to the left click popup and as items in the right click menu.
Changes in Maps: nextcloud/maps@697931d