Skip to content

Fix laggy high resolution videos in Chromium #6153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Aug 27, 2021
Merged

Fix laggy high resolution videos in Chromium #6153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/utils/webrtc/simplewebrtc/localmedia.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ LocalMedia.prototype.isLocalMediaActive = function() {
* resolution, so if the camera does not have such resolution it will still
* return the highest resolution available without failing.
*
* A high frame rate needs to be requested too, as some cameras offer high
* resolution but with low frame rates, so Chromium could end providing a laggy
* high resolution video. If the frame rate is requested too then Chromium needs
* to balance all the constraints and thus provide a video without the highest
* resolution but with an acceptable frame rate.
*
* @param {object} constraints the constraints to be adjusted
*/
LocalMedia.prototype._adjustVideoConstraintsForChromium = function(constraints) {
Expand All @@ -177,6 +183,7 @@ LocalMedia.prototype._adjustVideoConstraintsForChromium = function(constraints)

constraints.video.width = 1920
constraints.video.height = 1200
constraints.video.frameRate = 60
}

LocalMedia.prototype.start = function(mediaConstraints, cb, context) {
Expand Down