Skip to content

Don't use the avatar for the callview background, to save O(n^2) requests #6798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcoambrosini merged 1 commit into from
Mar 23, 2022
Merged

Don't use the avatar for the callview background, to save O(n^2) requests #6798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 0 additions & 95 deletions src/components/CallView/shared/VideoBackground.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,33 +29,7 @@
</template>

<script>
import { average } from 'color.js'
import axios from '@nextcloud/axios'
import usernameToColor from '@nextcloud/vue/dist/Functions/usernameToColor'
import { generateUrl } from '@nextcloud/router'
import { getBuilder } from '@nextcloud/browser-storage'

const browserStorage = getBuilder('nextcloud').persist().build()

// note: this info is shared with the Avatar component
/**
* @param {string} userId ID of the user
*/
function getUserHasAvatar(userId) {
const flag = browserStorage.getItem('user-has-avatar.' + userId)
if (typeof flag === 'string') {
return Boolean(flag)
}
return null
}

/**
* @param {string} userId ID of the user
* @param {string} flag The boolean flag as string
*/
function setUserHasAvatar(userId, flag) {
browserStorage.setItem('user-has-avatar.' + userId, flag)
}

export default {
name: 'VideoBackground',
Expand All @@ -71,25 +45,8 @@ export default {
},
},

data() {
return {
hasPicture: false,
}
},

computed: {
backgroundImageAverageColor() {
if (!this.backgroundImageUrl) {
return ''
}

return this.$store.getters.getCachedBackgroundImageAverageColor(this.backgroundImageUrl)
},
backgroundColor() {
if (this.hasPicture) {
return this.backgroundImageAverageColor
}

// If the prop is empty. We're not checking for the default value
// because the user's displayName might be '?'
if (!this.displayName) {
Expand All @@ -99,58 +56,6 @@ export default {
return `rgb(${color.r}, ${color.g}, ${color.b})`
}
},
backgroundImageUrl() {
if (!this.user) {
return null
}

return generateUrl(`avatar/${this.user}/64`)
},
},

watch: {
backgroundImageUrl: {
immediate: true,
handler() {
if (!this.backgroundImageUrl) {
return
}

if (this.backgroundImageAverageColor) {
// Already calculated, no need to do it again.
return
}

average(this.backgroundImageUrl, { format: 'hex' }).then(color => {
this.$store.dispatch('setCachedBackgroundImageAverageColor', {
videoBackgroundId: this.backgroundImageUrl,
backgroundImageAverageColor: color,
})
})
},
},
},

async beforeMount() {
if (!this.user) {
return
}

// check if hasAvatar info is already known
const userHasAvatar = getUserHasAvatar(this.user)
if (typeof userHasAvatar === 'boolean') {
this.hasPicture = userHasAvatar
return
}

try {
await axios.get(generateUrl(`avatar/${this.user}/64`))

this.hasPicture = true
setUserHasAvatar(this.user, true)
} catch (exception) {
console.debug(exception)
}
},
}
</script>
Expand Down