Skip to content

Handle all user status changes in case of "End meeting for all" in 1 … #6894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 2 commits into from
Feb 28, 2022
Merged

Handle all user status changes in case of "End meeting for all" in 1 … #6894

nickvergessen merged 2 commits into from
Feb 28, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 10, 2022 •
edited
Loading

…execution

@nickvergessen nickvergessen added this to the 💛 Next Major (24) milestone Feb 10, 2022
@nickvergessen nickvergessen added the feature: meetings 📅 Covering the webinary usecase incl. Lobby label Feb 10, 2022
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 11, 2022

Turning to draft until server is in

@nickvergessen nickvergessen marked this pull request as draft February 11, 2022 14:21
@nickvergessen nickvergessen force-pushed the techdebt/noid/improve-user-status-update-handling branch from 9ff0d5c to a527a74 Compare February 23, 2022 10:18
@nickvergessen nickvergessen marked this pull request as ready for review February 23, 2022 10:18
@nickvergessen nickvergessen force-pushed the techdebt/noid/improve-user-status-update-handling branch from a527a74 to 904236d Compare February 25, 2022 20:02
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 25, 2022

Rebased and lib bumped

vitormattos
vitormattos reviewed Feb 25, 2022
View reviewed changes
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests?

@nickvergessen nickvergessen mentioned this pull request Feb 25, 2022
Merged
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 28, 2022

Integration tests?

You fine with creating an issue about this?

@nickvergessen nickvergessen mentioned this pull request Feb 28, 2022
Closed
@nickvergessen nickvergessen merged commit 193d3b2 into master Feb 28, 2022
@nickvergessen nickvergessen deleted the techdebt/noid/improve-user-status-update-handling branch February 28, 2022 14:42
@nickvergessen nickvergessen mentioned this pull request Feb 28, 2022
Open
@nickvergessen
Copy link
Member Author

nickvergessen commented Feb 28, 2022

You fine with creating an issue about this?

Reported at #6947

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

+1 more reviewer

@vitormattos vitormattos vitormattos left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review bug feature: call 📹 Voice and video calls feature: meetings 📅 Covering the webinary usecase incl. Lobby performance 🚀

Projects

💬 Talk team
Archived in project

Milestone

v14.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @vitormattos @CarlSchwan