Skip to content

Conversation

@backportbot-nextcloud
Copy link

backport of #6929

Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this about outdated dependency?

ERROR: InvalidArgument - lib/Controller/SettingsController.php:111:52 - Argument 1 of OCP\Files\Storage::instanceOfStorage expects class-string<OCP\Files\Storage\IStorage>, OCA\Files_Sharing\SharedStorage::class provided (see https://psalm.dev/004)
				return !$node->getStorage()->instanceOfStorage(SharedStorage::class);


ERROR: InvalidArgument - lib/Files/Util.php:72:48 - Argument 1 of OCP\Files\Storage::instanceOfStorage expects class-string<OCP\Files\Storage\IStorage>, OCA\Files_Sharing\SharedStorage::class provided (see https://psalm.dev/004)
			if (!$node->getStorage()->instanceOfStorage(SharedStorage::class)) {

@nickvergessen
Copy link
Member

Seems a server change? Also happens on master

@vitormattos
Copy link
Contributor

vitormattos commented Mar 2, 2022

@nickvergessen we will need fix the Psalm issue at stable23 here or in a new PR or will ignore it?
I think this can throw error if isn't only an annotation question.

@nickvergessen
Copy link
Member

Need to fix in stable23... lemme look into it

@nickvergessen
Copy link
Member

#6952

@nickvergessen nickvergessen merged commit 5eaad00 into stable23 Mar 3, 2022
@nickvergessen nickvergessen deleted the backport/6929/stable23 branch March 3, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants