Combine last_activity and last_message update where possible

Signed-off-by: Joas Schilling <[email protected]>

lib/AppInfo/Application.php

@@ -42,7 +42,6 @@
 use OCA\Talk\Deck\DeckPluginLoader;
 use OCA\Talk\Events\AttendeesAddedEvent;
 use OCA\Talk\Events\AttendeesRemovedEvent;
-use OCA\Talk\Events\ChatEvent;
 use OCA\Talk\Events\RoomEvent;
 use OCA\Talk\Federation\CloudFederationProviderTalk;
 use OCA\Talk\Files\Listener as FilesListener;
@@ -82,7 +81,6 @@
 use OCP\AppFramework\Bootstrap\IBootstrap;
 use OCP\AppFramework\Bootstrap\IRegistrationContext;
 use OCP\AppFramework\IAppContainer;
-use OCP\AppFramework\Utility\ITimeFactory;
 use OCP\Collaboration\Resources\IProviderManager;
 use OCP\EventDispatcher\IEventDispatcher;
 use OCP\Federation\ICloudFederationProvider;
@@ -172,7 +170,6 @@ public function boot(IBootContext $context): void {
 		ShareListener::register($dispatcher);
 		StatusListener::register($dispatcher);
 
-		$this->registerRoomActivityHooks($dispatcher);
 		$this->registerChatHooks($dispatcher);
 		$context->injectFn(\Closure::fromCallable([$this, 'registerCloudFederationProviderManager']));
 	}
@@ -215,22 +212,6 @@ protected function registerNavigationLink(IServerContainer $server): void {
 		});
 	}
 
-	protected function registerRoomActivityHooks(IEventDispatcher $dispatcher): void {
-		$listener = function (ChatEvent $event): void {
-			if ($event->shouldSkipLastActivityUpdate()) {
-				return;
-			}
-
-			$room = $event->getRoom();
-			/** @var ITimeFactory $timeFactory */
-			$timeFactory = $this->getContainer()->query(ITimeFactory::class);
-			$room->setLastActivity($timeFactory->getDateTime());
-		};
-
-		$dispatcher->addListener(ChatManager::EVENT_AFTER_MESSAGE_SEND, $listener);
-		$dispatcher->addListener(ChatManager::EVENT_AFTER_SYSTEM_MESSAGE_SEND, $listener);
-	}
-
 	protected function registerChatHooks(IEventDispatcher $dispatcher): void {
 		$listener = function (RoomEvent $event): void {
 			/** @var ChatManager $chatManager */

lib/Chat/ChatManager.php

@@ -248,6 +248,8 @@ public function sendMessage(Room $chat, Participant $participant, string $actorT
 			if ($comment->getActorType() !== 'bots' || $comment->getActorId() === 'changelog') {
 				$chat->setLastMessage($comment);
 				$this->unreadCountCache->clear($chat->getId() . '-');
+			} else {
+				$chat->setLastActivity($comment->getCreationDateTime());
 			}
 
 			$alreadyNotifiedUsers = [];

lib/Room.php

@@ -768,7 +768,6 @@ public function setPassword(string $password): bool {
 	 * @return bool
 	 */
 	public function setLastActivity(\DateTime $now): bool {
-		// FIXME combine with setLastMessage and delay in case of multiple system messages
 		$update = $this->db->getQueryBuilder();
 		$update->update('talk_rooms')
 			->set('last_activity', $update->createNamedParameter($now, 'datetime'))
@@ -830,11 +829,13 @@ public function setLastMessage(IComment $message): void {
 		$update = $this->db->getQueryBuilder();
 		$update->update('talk_rooms')
 			->set('last_message', $update->createNamedParameter((int) $message->getId()))
+			->set('last_activity', $update->createNamedParameter($message->getCreationDateTime(), 'datetime'))
 			->where($update->expr()->eq('id', $update->createNamedParameter($this->getId(), IQueryBuilder::PARAM_INT)));
 		$update->executeStatement();
 
 		$this->lastMessage = $message;
 		$this->lastMessageId = (int) $message->getId();
+		$this->lastActivity = $message->getCreationDateTime();
 	}
 
 	public function resetActiveSince(): bool {

lib/Service/ParticipantService.php

@@ -442,7 +442,6 @@ public function addUsers(Room $room, array $participants, ?IUser $addedBy = null
 
 	protected function updateRoomLastMessage(Room $room, IComment $message): void {
 		$room->setLastMessage($message);
-		$room->setLastActivity($message->getCreationDateTime());
 		$lastMessageCache = $this->cacheFactory->createDistributed('talk/lastmsgid');
 		$lastMessageCache->remove($room->getToken());
 		$unreadCountCache = $this->cacheFactory->createDistributed('talk/unreadcount');