Reset all in_call flags in one go #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Feb 26, 2022
nickvergessen
commented
- Replaces O(n) queries with a single query in the "End meeting for all" case
nickvergessen
added
3. to review
bug
feature: meetings 📅
danxuliu
requested changes
Mar 2, 2022
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
When the HPB is used now the call is not properly ended; the inCall flag of the participants in the participants->update event sent by the external signaling server has its previous value rather than 0 (so the clients of other participants are not aware that they are no longer in the call).
Member
Author
|
Lemme retry with less users manually (I always ran into #6948 with my automated test) |
Member
Author
|
🤦🏼 Fixed, used the wrong ID column. |
vitormattos
approved these changes
Mar 2, 2022
Contributor
|
Only need solve the fixup and DCO tests before merge. |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/reset-in_call-flag-in-one-query
branch
from
0a30e4f to
d2e03f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.