Skip to content

Combine multiple system messages updates #6943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 3 commits into from
Mar 11, 2022
Merged

Combine multiple system messages updates #6943

nickvergessen merged 3 commits into from
Mar 11, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 28, 2022 •
edited
Loading

  • Only update last_message once, when creating multiple system chat messages
  • Combine the update of last message and last activity
  • Only push one update to the HPB

Fix #6944

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants performance 🚀 labels Feb 28, 2022
@nickvergessen nickvergessen added this to the 💛 Next Major (24) milestone Feb 28, 2022
@nickvergessen nickvergessen mentioned this pull request Feb 28, 2022
Merged
@nickvergessen nickvergessen force-pushed the bugfix/noid/combine-multiple-system-messages-updates branch from 329caf0 to 51402bb Compare February 28, 2022 09:25
@nickvergessen nickvergessen mentioned this pull request Feb 28, 2022
Closed
@nickvergessen nickvergessen mentioned this pull request Feb 28, 2022
Closed
@nickvergessen nickvergessen force-pushed the bugfix/noid/combine-multiple-system-messages-updates branch from cfff08e to 104663d Compare March 2, 2022 13:46
vitormattos
vitormattos reviewed Mar 4, 2022
View reviewed changes
@nickvergessen
Only update the last_message and last_activity once
4348f61 
Especially when adding multiple system messages we updated the room
data way too often.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Combine last_activity and last_message update where possible
dcc6291 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Emit a event so the HPB can send the update to the participants
b78ce07 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen force-pushed the bugfix/noid/combine-multiple-system-messages-updates branch from 104663d to b78ce07 Compare March 8, 2022 11:11
@nickvergessen nickvergessen merged commit 8840408 into master Mar 11, 2022
@nickvergessen nickvergessen deleted the bugfix/noid/combine-multiple-system-messages-updates branch March 11, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danxuliu danxuliu Awaiting requested review from danxuliu

1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants performance 🚀

Projects

None yet

Milestone

v14.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Creating multiple system messages in one request sends multiple requests to the HPB

3 participants

@nickvergessen @vitormattos