Fix call flags update when track is disabled #7013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the call flags were updated after a renegotiation the senders were checked to decide the flags to set. However, only the track attribute was checked; when a track is disabled the track is nullified in the sender and stored in "trackDisabled" instead, so the call flags were not properly set if any of the tracks was disabled when a new one was added. Note that when a local track is replaced the call flags are updated and, in that case, the right flags are used, so sometimes this issue could be masked by that. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
nickvergessen
approved these changes
Mar 17, 2022
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Member
|
/backport to stable23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the call flags were updated after a renegotiation the senders were checked to decide the flags to set. However, only the track attribute was checked; when a track is disabled the track is nullified in the sender and stored in
trackDisabledinstead, so the call flags were not properly set if any of the tracks was disabled when a new one was added.Note that when a local track is replaced the call flags are updated and, in that case, the right flags are used, so sometimes this issue could be masked by that.
How to test
Result with this pull request
The call flags for the participant were set to 7
Result without this pull request
The call flags for the participant were set to 5