Skip to content

Fix media automatically enabled after selecting a device during a call #7014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 11 commits into from
Mar 17, 2022
Merged

Fix media automatically enabled after selecting a device during a call #7014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2a65ecd
Add unit tests for TrackToStream
danxuliu Mar 9, 2022
864ff7e
Trigger event when same input track is set again with different state
danxuliu Mar 9, 2022
8bb2d39
Add unit tests for TrackEnabler
danxuliu Mar 9, 2022
951d082
Force enabled state before setting output track
danxuliu Mar 9, 2022
1eaf569
Set initial media state based on the current tracks
danxuliu Mar 11, 2022
b073cdf
Set enabled state in model based on the current track state
danxuliu Mar 11, 2022
19f1ea3
Fix media not disabled when not available
danxuliu Mar 14, 2022
3af8e1a
Fix state not saved to local storage if call started without media
danxuliu Mar 17, 2022
0915b5c
Rename method to better match its behaviour
danxuliu Mar 17, 2022
69dffa6
Replace code block with call to identical method
danxuliu Mar 17, 2022
caf6e21
Fix initial state not set when joining a call without media
danxuliu Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/utils/media/pipeline/TrackEnabler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,15 @@ export default class TrackEnabler extends TrackSinkSource {
}

_handleInputTrack(trackId, track) {
this._setOutputTrack('default', track)

// Ignore the enabled state of the input and force the desired state by
// the node. The state must be forced before setting the output track to
// ensure that it will have the desired state from the start (and thus
// "_setOutputTrackEnabled" can not be used).
if (track && track.enabled !== this._enabled) {
this._setOutputTrackEnabled('default', this._enabled)
track.enabled = this._enabled
}

this._setOutputTrack('default', track)
}

_handleInputTrackEnabled(trackId, enabled) {
Expand Down
Loading