Skip to content

👍 Reactions part two #7024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 10 commits into from
Mar 24, 2022
Merged

👍 Reactions part two #7024

nickvergessen merged 10 commits into from
Mar 24, 2022

Conversation

@marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Mar 18, 2022

No description provided.

@marcoambrosini marcoambrosini self-assigned this Mar 18, 2022
@marcoambrosini marcoambrosini changed the title Feature/noid/reactions part two Reactions part two Mar 18, 2022
@marcoambrosini marcoambrosini changed the title Reactions part two ❤️❤️ Reactions part two Mar 18, 2022
@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch from 901ed9f to 0ad7f4c Compare March 18, 2022 15:38
@nickvergessen
Copy link
Member

nickvergessen commented Mar 21, 2022 •
edited by marcoambrosini
Loading

  • Reaction option shows in read-only conversations like the Talk Update?

@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch 2 times, most recently from 3fa7d48 to c07934b Compare March 21, 2022 13:46
@nickvergessen nickvergessen changed the title ❤️❤️ Reactions part two 👍 Reactions part two Mar 21, 2022
@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch from 8ad89be to 5326edf Compare March 22, 2022 11:44
@marcoambrosini
Copy link
Member Author

marcoambrosini commented Mar 23, 2022 •
edited
Loading

  • only allow reactions for message type comment (no system messages)

@nickvergessen

This comment was marked as resolved.

Sign in to view
@nickvergessen nickvergessen mentioned this pull request Mar 23, 2022
Open
@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch from 987c14b to 3cea53c Compare March 24, 2022 12:23
nickvergessen
nickvergessen requested changes Mar 24, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.DS_Store file exists

@nickvergessen nickvergessen removed the request for review from PVince81 March 24, 2022 12:57
@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch from 3cea53c to fdb7cba Compare March 24, 2022 13:01
@nickvergessen
Copy link
Member

nickvergessen commented Mar 24, 2022

Tests spam an error:

    console.error node_modules/vuex/dist/vuex.common.js:878
      [vuex] duplicate getter key: userHasReacted
    console.debug src/components/MessagesList/MessagesGroup/Message/Message.vue:664
      adding reaction
    console.error node_modules/vuex/dist/vuex.common.js:878
      [vuex] duplicate getter key: userHasReacted
    console.debug src/components/MessagesList/MessagesGroup/Message/Message.vue:672
      user has already reacted, removing reaction

@nickvergessen
Copy link
Member

nickvergessen commented Mar 24, 2022 •
edited
Loading

@nickvergessen nickvergessen mentioned this pull request Mar 24, 2022
Merged
@marcoambrosini marcoambrosini force-pushed the feature/noid/reactions-part-two branch from 9c77a4e to 55923f4 Compare March 24, 2022 15:12
@nickvergessen nickvergessen merged commit 3b43e06 into master Mar 24, 2022
@nickvergessen nickvergessen deleted the feature/noid/reactions-part-two branch March 24, 2022 16:00
@nickvergessen nickvergessen mentioned this pull request Mar 24, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

@nikola-gladovic nikola-gladovic Awaiting requested review from nikola-gladovic

Assignees

@marcoambrosini marcoambrosini

Labels

4. to release enhancement feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

v14.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@marcoambrosini @nickvergessen