Skip to content

Conversation

@nickvergessen
Copy link
Member

Fix #3089

@nickvergessen nickvergessen added 3. to review bug feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants labels Jun 10, 2022
@nickvergessen nickvergessen added this to the 💚 Next Major (25) milestone Jun 10, 2022
@nickvergessen nickvergessen force-pushed the feature/3089/password-policy branch from 33c13f8 to 509d3ba Compare June 10, 2022 14:20
@nickvergessen nickvergessen marked this pull request as ready for review June 10, 2022 14:21
@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jun 11, 2022

Noticed two things

  1. I can't remove a password which was correctly set anymore (GUI reflects a removed password):
ScreenCaptureProject32.mp4
  1. When the password validation fails, the GUI still reflects a successful change:
ScreenCaptureProject33.mp4

@SystemKeeper
Copy link
Contributor

  1. Conversation is still created, although an error occured:
ScreenCaptureProject34.mp4

@nickvergessen
Copy link
Member Author

Yeah noticed too that there are many issues with the field.
Also when you open the settings and the conversation has a password already, the input is not visible 🙈

@nickvergessen
Copy link
Member Author

Conversation is still created, although an error occured:

That is actually a sad issue, as we currently set the password after the creation. Basically boils down to:
#2874

@SystemKeeper
Copy link
Contributor

Oh I see. Then this problem is out of scope for this PR and currently expected.

@nickvergessen
Copy link
Member Author

Or we use this moment to implement it

@nickvergessen nickvergessen self-assigned this Jun 13, 2022
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need fix cs

@nickvergessen nickvergessen marked this pull request as draft June 13, 2022 18:07
@nickvergessen nickvergessen force-pushed the feature/3089/password-policy branch from 509d3ba to 17d47a0 Compare June 14, 2022 09:38
@nickvergessen nickvergessen marked this pull request as ready for review June 14, 2022 14:17
@nickvergessen
Copy link
Member Author

Also when you open the settings and the conversation has a password already, the input is not visible 🙈

@marcoambrosini maybe you can help with the missing input field?

@SystemKeeper
Copy link
Contributor

Haven’t tested, but isn’t there special handling for removing the password (eg setting the password to „“) needed?

@nickvergessen
Copy link
Member Author

I had wrapped the event dispatch in an if checking for non empty string.... But seems it got removed by a rebase or something

@nickvergessen nickvergessen force-pushed the feature/3089/password-policy branch from 17d47a0 to 5fdedaa Compare June 29, 2022 08:44
@nickvergessen
Copy link
Member Author

Haven’t tested, but isn’t there special handling for removing the password (eg setting the password to „“) needed?

Fixed now

@nickvergessen nickvergessen merged commit 57b28f6 into master Jun 30, 2022
@nickvergessen nickvergessen deleted the feature/3089/password-policy branch June 30, 2022 07:20
@nickvergessen nickvergessen mentioned this pull request Oct 4, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: settings ⚙️ Settings and config related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enforce password policy for shared links

4 participants