-
Notifications
You must be signed in to change notification settings - Fork 509
Implement password policy checker #7473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
33c13f8 to
509d3ba
Compare
|
Noticed two things
ScreenCaptureProject32.mp4
ScreenCaptureProject33.mp4 |
ScreenCaptureProject34.mp4 |
|
Yeah noticed too that there are many issues with the field. |
That is actually a sad issue, as we currently set the password after the creation. Basically boils down to: |
|
Oh I see. Then this problem is out of scope for this PR and currently expected. |
|
Or we use this moment to implement it |
vitormattos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only need fix cs
509d3ba to
17d47a0
Compare
@marcoambrosini maybe you can help with the missing input field? |
|
Haven’t tested, but isn’t there special handling for removing the password (eg setting the password to „“) needed? |
|
I had wrapped the event dispatch in an if checking for non empty string.... But seems it got removed by a rebase or something |
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
17d47a0 to
5fdedaa
Compare
Fixed now |
Fix #3089