Allow to disable talk updates

[pboguslawski]

This mod allows one to disable talk updates using new global disable_ads boolean setting in config.php.

Related: #3128
Author-Change-Id: IB#1121121

[nickvergessen]

disable_ads is a very disrespectful config name.

Also if this is only used for the Talk changelog channel, it should be an app config for the app instead (and mostlikely come with an option to toggle it in the admin settings)

[pboguslawski]

disable_ads is a very disrespectful config name.

Also if this is only used for the Talk changelog channel, it should be an app config for the app instead (and mostlikely come with an option to toggle it in the admin settings)

We plan to use it for disabling this and other ads we don't want to see in our setup; global disable ads switch is more appropriate for such stuff and may be used in other places also in the future to avoid nc overconfiguration. This PR is because other people find this option valuable:

• How can i remove Talk Updates #3128
• ibpl@261c7af#commitcomment-77972717

Feel free to adapt this PR to your requirements if you don't like global switch - we will rather continue to use disable_ads like in this PR.

[nickvergessen]

I discussed it with others and we will accept a dedicated appconfig for this.
A generic "disable_ads" (and again the changelog is not advertisement, it's explaining users what they can do in the newest version?) is not acceptable.

[pboguslawski]

I discussed it with others and we will accept a dedicated appconfig for this. A generic "disable_ads" (and again the changelog is not advertisement, it's explaining users what they can do in the newest version?) is not acceptable.

spreed.changelog switch for this function LGTM (PR updated)

[pboguslawski]

Let me know if DCO and rebasing to master is required.

[nickvergessen]

Let me know if DCO and rebasing to master is required.

That would be awesome

[pboguslawski]

Just force-pushed master compatible version with DCO (2e37b6a). Please change this PR target from stable24 to master.

[nickvergessen]

Seems CI chocked on it. So repushed inside the org at #7613