Skip to content

Reduce number of queries required to read shares #7743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 11 commits into from
Aug 24, 2022
Merged

Reduce number of queries required to read shares #7743

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
254e796
Reduce number of queries required to read shares
starypatyk Aug 13, 2022
3e17b5c
Apply suggestions from code review
starypatyk Aug 17, 2022
03f6476
Invalidate cache on delete/update function calls
starypatyk Aug 17, 2022
4c4f43a
Minor refactoring
starypatyk Aug 17, 2022
e8bd174
Refactor getShareById/getSharesByIds
starypatyk Aug 17, 2022
78a4f65
lint
starypatyk Aug 22, 2022
31e130a
Static analysis (psalm)
starypatyk Aug 22, 2022
dcb7869
Trying to fix failing PHPUnit tests
starypatyk Aug 22, 2022
26497b4
Return type annotation corrected
starypatyk Aug 23, 2022
aa9921d
Misleading comment corrected
starypatyk Aug 23, 2022
e35b191
Fix docs
nickvergessen Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Trying to fix failing PHPUnit tests 
Signed-off-by: Dariusz Olszewski <[email protected]>
  • Loading branch information
@starypatyk
starypatyk committed Aug 22, 2022
commit dcb78699c1b1b6bf4d63c35495b67ffaa0ea5379
5 changes: 5 additions & 0 deletions tests/php/Controller/ChatControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
use OCA\Talk\Service\AttachmentService;
use OCA\Talk\Service\ParticipantService;
use OCA\Talk\Service\SessionService;
use OCA\Talk\Share\RoomShareProvider;
use OCP\App\IAppManager;
use OCP\AppFramework\Http;
use OCP\AppFramework\Http\DataResponse;
Expand Down Expand Up @@ -76,6 +77,8 @@ class ChatControllerTest extends TestCase {
protected $guestManager;
/** @var MessageParser|MockObject */
protected $messageParser;
/** @var RoomShareProvider|MockObject */
protected $roomShareProvider;
/** @var IManager|MockObject */
protected $autoCompleteManager;
/** @var IUserStatusManager|MockObject */
Expand Down Expand Up @@ -118,6 +121,7 @@ public function setUp(): void {
$this->attachmentService = $this->createMock(AttachmentService::class);
$this->guestManager = $this->createMock(GuestManager::class);
$this->messageParser = $this->createMock(MessageParser::class);
$this->roomShareProvider = $this->createMock(RoomShareProvider::class);
$this->autoCompleteManager = $this->createMock(IManager::class);
$this->statusManager = $this->createMock(IUserStatusManager::class);
$this->matterbridgeManager = $this->createMock(MatterbridgeManager::class);
Expand Down Expand Up @@ -155,6 +159,7 @@ private function recreateChatController() {
$this->attachmentService,
$this->guestManager,
$this->messageParser,
$this->roomShareProvider,
$this->autoCompleteManager,
$this->statusManager,
$this->matterbridgeManager,
Expand Down