Fix permissions returned by getSharesInFolder

[starypatyk]

When working on nextcloud/server#34918, I have noticed that after applying changes proposed in that PR, incorrect permissions are returned for room shares.

This seems to be caused by the fact that the database query issued in RoomShareProvider::getSharesInFolder returnes two columns named permissions - one from the oc_shares table and a second one from oc_filecache. Which column is then used by the PHP code probably depends on the database driver used and maybe some random factors. In my case (MariaDB) the wrong column was consistently used.

In this PR I propose to change the SELECT part of the query to match other methods in the class - getSharesByIds and getSharedWith.

This change also means that the node data will be stored in the cache: https://github.com/nextcloud/spreed/blob/master/lib/Share/RoomShareProvider.php#L313, but I do not know what side effects this might introduce.

[nickvergessen]

Looks good

[nickvergessen]

When working on nextcloud/server#34918, I have noticed that after applying changes proposed in that PR, incorrect permissions are returned for room shares.

So another server PR breaking things? :P

Can we for the fun of it send a PR to talk to run integration tests against it? (Replace CORE_BRANCH: master with your PR in .drone.yml? (That being said, you didn't push the branch to the org, so it won't work for now)

[starypatyk]

@nickvergessen

So another server PR breaking things? :P

I would rather say exposing an existing issue... 😉
BTW - it started here: nextcloud/android#10783

Can we for the fun of it send a PR to talk to run integration tests against it? (Replace CORE_BRANCH: master with your PR in .drone.yml? (That being said, you didn't push the branch to the org, so it won't work for now)

As I understand I do not have permissions to push to nextcloud/server or nextcloud/spreed directly. It seems however, that changing CORE_BRANCH: master to CORE_BRANCH: refs/pull/34918/head in .drone.yml might do the trick.

[nickvergessen]

As I understand I do not have permissions to push to nextcloud/server or nextcloud/spreed directly.

You are a member of our GitHub Organisation and therefor should have permissions to push branches just fine.

[nickvergessen]

Added a PR to test that branch at #8312

[nickvergessen]

Confirmed broken in #8312
Pushed your fix there

[nickvergessen]

Fixes it as per #8312

So 👍