Skip to content

Remove poll data when deleting the message #8351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Nov 17, 2022
Merged

Remove poll data when deleting the message #8351

nickvergessen merged 1 commit into from
Nov 17, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 15, 2022 •
edited
Loading

Fix #8342

🚧 Todo list

  • Remove all data
  • Make sure the "Create" message is neutralized
  • Make sure the "Close" message is neutralized
  • UI "Show result" button on deleted polls is not removed and title of the poll is still leaked in the "result message"

🏁 Checklist

@nickvergessen nickvergessen added 2. developing bug feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: polls 📊 labels Nov 15, 2022
@nickvergessen nickvergessen added this to the 💟 Next Major (26) milestone Nov 15, 2022
@nickvergessen nickvergessen self-assigned this Nov 15, 2022
@nickvergessen nickvergessen mentioned this pull request Nov 15, 2022
Closed
@nickvergessen nickvergessen force-pushed the bugfix/8342/remove-poll-data-on-deletion branch from 158f79c to f25b655 Compare November 16, 2022 07:44
@nickvergessen nickvergessen marked this pull request as ready for review November 16, 2022 07:44
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 16, 2022

/backport to stable25

vitormattos
vitormattos reviewed Nov 16, 2022
View reviewed changes
@nickvergessen nickvergessen force-pushed the bugfix/8342/remove-poll-data-on-deletion branch from f25b655 to 6bedf30 Compare November 16, 2022 15:08
@nickvergessen nickvergessen merged commit 2d3c1b2 into master Nov 17, 2022
@nickvergessen nickvergessen deleted the bugfix/8342/remove-poll-data-on-deletion branch November 17, 2022 05:24
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

1 more reviewer

@vitormattos vitormattos vitormattos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@nickvergessen nickvergessen

Labels

4. to release bug feature: api 🛠️ OCS API for conversations, chats and participants feature: frontend 🖌️ "Web UI" client feature: polls 📊

Projects

None yet

Milestone

v16.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

do not show results of deleted polls

3 participants

@nickvergessen @vitormattos