Skip to content

Allow to disable public conversations#8357

Draft
nickvergessen wants to merge 9 commits intomainfrom
feature/521/disable-public-conversations
Draft

Allow to disable public conversations#8357
nickvergessen wants to merge 9 commits intomainfrom
feature/521/disable-public-conversations

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 16, 2022 •
edited
Loading

🚧 TODO

  • Rebased Added parameter to disallow creating of rooms with public access #8082 on latest master
  • Pushed to the organisation so we can all collaborate
  • Boolean config to enable and disable public conversations
  • Prevent creating such conversations via API
  • Don't allow adding email addresses which would also make the room public
  • Hide the option in the conversation creation dialog
  • Hide the option in the conversation settings
  • Add a config capability
  • Write integration tests for known API calls
    • Creation
    • Changing type
    • Inviting email

Follow up possible

  • Add an admin setting in the UI

🏁 Checklist

pboguslawski and others added 5 commits November 16, 2022 13:02
@pboguslawski @nickvergessen
Added parameter to disallow creating of rooms with public access
53d842e 
Added spreed application config parameter `public_rooms_allowed` to disallow
creating of rooms with public (guest via link) access (i.e. for internal
Nextcloud setups). Use

```
occ config:app:set spreed public_rooms_allowed --value 'yes'
```

to allow (default if not set) and

```
occ config:app:set spreed public_rooms_allowed --value 'no'
```

to disallow creating of rooms with public access.

Related: #521
Author-Change-Id: IB#1126215
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@pboguslawski @nickvergessen
Adding e-mail addresses to room disabled when public rooms are disall…
78fda1c 
…owed

Fixes: a38fdfd
Related: #8082 (review)
Author-Change-Id: IB#1126215
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
@nickvergessen
Prevent creating public rooms on the API
bf2aeb4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Remove duplicated initial state
97b3216 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Don't ask for emails in first place instead of not rendering them
b50604c 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 3. to review enhancement feature: settings ⚙️ Settings and config related issues feature: api 🛠️ OCS API for conversations, chats and participants labels Nov 16, 2022
@nickvergessen nickvergessen added this to the 💟 Next Major (26) milestone Nov 16, 2022
@nickvergessen nickvergessen self-assigned this Nov 16, 2022
@nickvergessen nickvergessen mentioned this pull request Nov 16, 2022
Closed
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 16, 2022

@pboguslawski shall we take over the remaining tasks?

@pboguslawski
Copy link
Contributor

pboguslawski commented Nov 16, 2022

No time resources now to help; feel free to adjust our PR according to your best practices. Will take a look at result in a few days. Thank you.

@pboguslawski
Copy link
Contributor

pboguslawski commented Jan 24, 2023 •
edited
Loading

Didn't notice any problems in your solution.

shall we take over the remaining tasks

Yes please.

@nickvergessen nickvergessen removed this from the v18.0.0-beta.1 milestone Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nickvergessen nickvergessen

Labels

enhancement feature: api 🛠️ OCS API for conversations, chats and participants feature: settings ⚙️ Settings and config related issues

Projects

None yet

Milestone

🏖️ Next Major (34)

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @pboguslawski @danxuliu @Antreesy