Skip to content

Fix "Unread mentions" button occurence #8603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Jan 27, 2023
Merged

Fix "Unread mentions" button occurence #8603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/components/LeftSidebar/LeftSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
<NewGroupConversation v-if="canStartConversations" />
</div>
<template #list>
<li class="left-sidebar__list">
<ul ref="scroller"
class="scroller"
@scroll="debounceHandleScroll">
<li ref="container"
class="left-sidebar__list"
@scroll="debounceHandleScroll">
<ul class="scroller">
<NcAppNavigationCaption :class="{'hidden-visually': !isSearching}"
:title="t('spreed', 'Conversations')" />
<li role="presentation">
Expand Down Expand Up @@ -294,7 +294,7 @@ export default {
},
scrollBottomUnread() {
this.preventFindingUnread = true
this.$refs.scroller.scrollTo({
this.$refs.container.scrollTo({
top: this.firstUnreadPos - 150,
behavior: 'smooth',
})
Expand Down Expand Up @@ -472,7 +472,7 @@ export default {
// Checks whether the conversations list is scrolled all the way to the top
// or not
handleScroll() {
this.isScrolledToTop = this.$refs.scroller.scrollTop === 0
this.isScrolledToTop = this.$refs.container.scrollTop === 0
},
elementIsBelowViewpoint(container, element) {
return element.offsetTop > container.scrollTop + container.clientHeight
Expand All @@ -482,7 +482,7 @@ export default {
const unreadMentions = document.getElementsByClassName('unread-mention-conversation')
if (unreadMentions.length) {
unreadMentions.forEach(x => {
if (this.elementIsBelowViewpoint(this.$refs.scroller, x)) {
if (this.elementIsBelowViewpoint(this.$refs.container, x)) {
if (this.unreadNum === 0) {
this.firstUnreadPos = x.offsetTop
}
Expand Down Expand Up @@ -533,11 +533,12 @@ export default {
}

.unread-mention-button {
position: absolute;
position: absolute !important;
left: 50%;
transform: translateX(-50%);
z-index: 100;
bottom: 10px;
white-space: nowrap;
}

.conversations-search {
Expand Down