Skip to content

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Feb 14, 2023

Fix #6608

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
image image image image

🚧 TODO

  • Improve code style
  • Update labels
  • Call device settings on click if device is not available
  • Code review
  • Visual check

🏁 Checklist

Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep No audio / No video and add the second sentence after that

@Antreesy Antreesy force-pushed the fix/6608/local-media-controls-labels branch from cd44f38 to a24082d Compare February 15, 2023 16:50
@Antreesy Antreesy merged commit 779d285 into master Feb 16, 2023
@Antreesy Antreesy deleted the fix/6608/local-media-controls-labels branch February 16, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve label of the audio button "No audio"

4 participants