Fix hover effects for buttons in TopBar #8771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
added
3. to review
bug
regression
feature: frontend 🖌️
ShGKme
requested changes
Feb 20, 2023
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Works:
But I'd rename open event of TopBarMenu. Everything else looks good to me.
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/8766/fix-topbar-buttons-hover
branch
from
fc0be6d to
6395392
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8766
🚧 TODO
BreakoutRoomsEditorto parent component to get rid ofFragmentin TopBarMenu🏁 Checklist
docs/has been updated or is not required