feat(chat): Add capabilities for translation options #9321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
enhancement
feature: chat 💬
This was referenced Apr 17, 2023
skjnldsv
reviewed
Apr 18, 2023
Comment on lines
+40
to
+45
| protected IConfig $serverConfig, | ||
| protected Config $talkConfig, | ||
| protected ICommentsManager $commentsManager, | ||
| protected IUserSession $userSession, | ||
| protected IAppManager $appManager, | ||
| protected ITranslationManager $translationManager, |
skjnldsv
approved these changes
Apr 18, 2023
| protected Config $talkConfig, | ||
| protected ICommentsManager $commentsManager, | ||
| protected IUserSession $userSession, | ||
| protected IAppManager $appManager, |
There was a problem hiding this comment.
$appManager was private before.
Is that change on purpose?
Member
Author
There was a problem hiding this comment.
Yeah, I have protected as it prevents extending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏁 Checklist
docs/has been updated or is not required => feat(developer): Document translation API documentation#10047