Skip to content

RightSidebar improvements and bug fixes (participant tabs) #9371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 6 commits into from
May 4, 2023
Merged

RightSidebar improvements and bug fixes (participant tabs) #9371

Antreesy merged 6 commits into from
May 4, 2023

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 24, 2023 •
edited
Loading

☑️ Resolves

  • Check if participant belongs to conversation when updating his status (fix error when trying to get info from server about status while switching between conversations)

🚧 Tasks

  • Code review

🏁 Checklist

@Antreesy Antreesy self-assigned this Apr 24, 2023
@Antreesy Antreesy added this to the 💙 Next Major (27) milestone Apr 24, 2023
@Antreesy Antreesy marked this pull request as ready for review April 24, 2023 14:23
ShGKme
ShGKme reviewed Apr 24, 2023
View reviewed changes
@nickvergessen nickvergessen removed their request for review April 24, 2023 15:30
@Antreesy Antreesy force-pushed the fix/9345/group-chat-tabs branch from 28bbd71 to df22815 Compare April 25, 2023 06:35
@Antreesy Antreesy requested a review from ShGKme April 25, 2023 06:36
ShGKme
ShGKme approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@Antreesy Antreesy force-pushed the fix/9345/group-chat-tabs branch from 47ad038 to 3a213cd Compare May 4, 2023 08:51
@Antreesy
Copy link
Contributor Author

Antreesy commented May 4, 2023 •
edited
Loading

Rebased onto master with @nextcloud/vue 7.11.1

See last commit: component styles was adjusted

🖼️ Screenshots

🏚️ Before 🏡 After
image image

@Antreesy Antreesy requested review from ShGKme and nickvergessen May 4, 2023 08:55
ShGKme
ShGKme reviewed May 4, 2023
View reviewed changes
@ShGKme ShGKme self-requested a review May 4, 2023 10:46
@Antreesy Antreesy enabled auto-merge May 4, 2023 12:44
@Antreesy Antreesy merged commit 586d1e6 into master May 4, 2023
@Antreesy Antreesy deleted the fix/9345/group-chat-tabs branch May 4, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@Antreesy Antreesy

Labels

3. to review bug feature: frontend 🖌️ "Web UI" client

Projects

None yet

Milestone

17.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

Shared items tab focused for group chats Custom permission flag shown for moderators

3 participants

@Antreesy @ShGKme