fix(chat): Conversation avatar for mention chips #9383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: chat 💬
ShGKme
reviewed
Apr 26, 2023
src/components/MessagesList/MessagesGroup/Message/MessagePart/Mention.vue
Show resolved
Hide resolved
ShGKme
reviewed
Apr 26, 2023
Comment on lines
+93
to
+96
| isDarkTheme() { | ||
| return window.getComputedStyle(document.body) | ||
| .getPropertyValue('--background-invert-if-dark') === 'invert(100%)' | ||
| }, |
Contributor
There was a problem hiding this comment.
nitpick: This should not be computed effect
- It's not computed by design, there is no reactive dependencies in the computing
- A little bit more memory (it creates Watcher for reactivity and etc here)
- Each
Mentioninstance creates and compute it's own copy ofisDarkTheme
Proposal: make a constant outside of this component (just outside of component definition export default {} in this module or in a some common for reuse).
Comment on lines
+74
to
82
| .mention-bubble__icon.icon-group-forced-white, | ||
| .tribute-container .icon-group-forced-white { | ||
| background-image: url(../img/icon-contacts-white.svg); | ||
| } | ||
|
|
||
| .mention-bubble__icon.icon-user-forced-white, | ||
| .tribute-container .icon-user-forced-white { | ||
| background-image: url(../img/icon-user-white.svg) | ||
| } |
Contributor
There was a problem hiding this comment.
thought: Not a part of this PR
mention-bubble__icon is some internal class from @nextcloud/vue lib and not a part of public API. As this file with libraries overrides became bigger and bigger, I'd think about more safe alternative.
ShGKme
approved these changes
Apr 26, 2023
Contributor
ShGKme
left a comment
ShGKme
left a comment
There was a problem hiding this comment.
Tested and works fine on @nextcloud/vue@master.
But there are some non-bloking comments above.
nickvergessen
deleted the
bugfix/9188/conversation-avatar-for-mention-chips
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required