Skip to content

Conversation

@Antreesy
Copy link
Contributor

☑️ Resolves

  • Remove unused dependencies from project:
Package name Added since Unused since
color.js #4985 #6798
url-parse #2891 #9915
vue-resize #3739 #4985
extendable-media-recorder-wav-encoder-worker #5903 shipped with extendable-media-recorder-wav-encoder
workbox-webpack-plugin #5903 never used
terser-webpack-plugin #5903 never used
webpack-node-externals #2185 never used

🚧 Tasks

  • Manual testing (tested on prod build with web client + Chrome + Linux)

🏁 Checklist

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added feature: frontend 🖌️ "Web UI" client dependencies Pull requests that update a dependency file javascript labels Jul 14, 2023
@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jul 14, 2023
@Antreesy Antreesy self-assigned this Jul 14, 2023
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some details:

  • webpack-node-externals is not used and usually useful only on nodejs backend development
  • terser-webpack-plugin is used by @nextcloud/webpack-vue-config, but it can be safely removed as this is a direct dependency of Webpack (which is peer of @nextcloud/webpack-vue-config anyway)
  • workbox-webpack-plugin is for Service Workers what we do not use

Also tested, that it works in general, including audio messages from files sidebar and calls.

@Antreesy Antreesy merged commit feaf6cf into master Jul 14, 2023
@Antreesy Antreesy deleted the techdebt/noid/remove-unused-deps branch July 14, 2023 12:47
@Antreesy
Copy link
Contributor Author

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants