Skip to content

Wait for load of script before binding #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MorrisJobke merged 2 commits into from
Mar 25, 2019
Merged

Wait for load of script before binding #28

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf5f573
Wait for load of script before binding
rullzer Mar 25, 2019
d4ee607
Also move other drawSelf bind to onload
rullzer Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also move other drawSelf bind to onload 
Signed-off-by: Roeland Jago Douma <[email protected]>
  • Loading branch information
@rullzer
rullzer committed Mar 25, 2019
commit d4ee6076cc99cb9b6541b73c8bb6b1a1578aad43
3 changes: 1 addition & 2 deletions jquery.strengthify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,15 +207,14 @@
getWrapperFor(elemId).append('<div class="strengthify-tiles"></div>');
}

$elem.parent().on('scroll', drawSelf);

var script = document.createElement("script");
script.src = options.zxcvbn;
if (options.nonce !== null) {
script.setAttribute('nonce', options.nonce);
}

script.onload = function() {
$elem.parent().on('scroll', drawSelf);
$elem.bind('keyup input change', drawSelf);
}

Expand Down