Skip to content

[stable29] fix: notifications link for mobile / desktop error generating errors in v30 #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
Sep 26, 2024
Merged

[stable29] fix: notifications link for mobile / desktop error generating errors in v30 #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(notifications): Make action URLs absolute links to fix mobile and… 
… desktop

Signed-off-by: Josh <[email protected]>
  • Loading branch information
@joshtrichards @backportbot
joshtrichards authored and backportbot[bot] committed Sep 26, 2024
commit 22409bbf6784af440108c97e9911334d5d49b8cc
6 changes: 4 additions & 2 deletions lib/BackgroundJobs/AdminNotification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,17 @@ protected function run($argument): void {
->setSubject('updated')
->setObject('dummy', '23');

$enableLink = $this->url->linkToOCSRouteAbsolute('survey_client.Endpoint.enableMonthly');
$enableAction = $notification->createAction();
$enableAction->setLabel('enable')
->setLink($this->url->getAbsoluteURL('ocs/v2.php/apps/survey_client/api/v1/monthly'), 'POST')
->setLink($enableLink, 'POST')
->setPrimary(true);
$notification->addAction($enableAction);

$disableLink = $this->url->linkToOCSRouteAbsolute('survey_client.Endpoint.disableMonthly');
$disableAction = $notification->createAction();
$disableAction->setLabel('disable')
->setLink($this->url->getAbsoluteURL('ocs/v2.php/apps/survey_client/api/v1/monthly'), 'DELETE')
->setLink($disableLink, 'DELETE')
->setPrimary(false);
$notification->addAction($disableAction);

Expand Down