Skip to content

[stable14] Properly escape column name in "createFunction" call #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rullzer merged 1 commit into from
Oct 19, 2018
Merged

[stable14] Properly escape column name in "createFunction" call #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Properly escape column name in "createFunction" call 
Signed-off-by: Morris Jobke <[email protected]>
  • Loading branch information
@MorrisJobke
MorrisJobke committed Oct 19, 2018
commit 18040d4772cb87d249c3b8a627f17c38f3c0be03
6 changes: 3 additions & 3 deletions lib/Categories/Stats.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ protected function countStorages($type) {
* @return int
*/
protected function countEntries($tableName, $column = '*') {
$query = $this->connection->getQueryBuilder();

if ($column !== '*') {
$column = 'DISTINCT(' . $column . ')';
$column = 'DISTINCT(' . $query->getColumnName($column ) . ')';
}

$query = $this->connection->getQueryBuilder();
$query->selectAlias($query->createFunction('COUNT(' . $column . ')'), 'num_entries')
->from($tableName);
$result = $query->execute();
Expand Down