Skip to content

Conversation

@ChristophWurst
Copy link
Member

Fixes

 > phpunit -c tests/phpunit.xml tests/Unit
PHPUnit 9.6.3 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.2.28
Configuration: tests/phpunit.xml
Warning:       No code coverage driver available
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

PHP Fatal error:  During inheritance of JsonSerializable: Uncaught Return type of OCA\SuspiciousLogin\Service\Statistics\TrainingDataStatistics::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

/home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/lib/Service/Statistics/TrainingDataStatistics.php:42
/home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/lib/Service/Statistics/TrainingDataStatistics.php:14
/home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/tests/Unit/Service/AdminServiceTest.php:73
 in /home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/lib/Service/Statistics/TrainingDataStatistics.php on line 14
Script phpunit -c tests/phpunit.xml tests/Unit handling the test:unit event returned with error code 255
...
Error: Process completed with exit code 255.

on CI

@ChristophWurst ChristophWurst self-assigned this Jul 3, 2025
@ChristophWurst ChristophWurst added bug Something isn't working 3. to review labels Jul 3, 2025
@ChristophWurst ChristophWurst merged commit 6ca945d into master Jul 3, 2025
29 of 31 checks passed
@ChristophWurst ChristophWurst deleted the fix/php/json-serializable-return-type branch July 3, 2025 07:47
@ChristophWurst
Copy link
Member Author

/backport to stable31

@ChristophWurst
Copy link
Member Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants