Skip to content

fix(deps): bump amphp/parallel to v1.4.4. for PHP8.4 compatibility #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Jul 4, 2025
Merged

fix(deps): bump amphp/parallel to v1.4.4. for PHP8.4 compatibility #1014

ChristophWurst merged 1 commit into from
Jul 4, 2025

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Jul 4, 2025 •
edited
Loading

Ref amphp/parallel#220

Fixes

PHP Deprecated:  Amp\Parallel\Worker\pool(): Implicitly marking parameter $pool as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/vendor/amphp/parallel/lib/Worker/functions.php on line 18
PHP Deprecated:  Amp\Parallel\Worker\factory(): Implicitly marking parameter $factory as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/suspicious_login/suspicious_login/apps/suspicious_login/vendor/amphp/parallel/lib/Worker/functions.php on line 85

@ChristophWurst ChristophWurst self-assigned this Jul 4, 2025
@ChristophWurst ChristophWurst added bug Something isn't working 3. to review labels Jul 4, 2025
@ChristophWurst ChristophWurst enabled auto-merge July 4, 2025 08:43
@ChristophWurst ChristophWurst mentioned this pull request Jul 4, 2025
Merged
marcelklehr
marcelklehr approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice. Will do this in recognize as well 🎉

@ChristophWurst ChristophWurst merged commit f1562c5 into master Jul 4, 2025
31 checks passed
@ChristophWurst ChristophWurst deleted the fix/deps/amphp-prallel-php8.4 branch July 4, 2025 08:49
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ChristophWurst @marcelklehr