Reduce log messages when no model found #869
Conversation
victorlap
changed the title
victorlap
force-pushed
the
reduce-log-messages-when-no-model
branch
2 times, most recently
from
0a07172 to
898cf95
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
Thank you for the PR :)
I tested it and it works. I also left some minor feedback.
susnux
force-pushed
the
reduce-log-messages-when-no-model
branch
from
b2a6d71 to
8050aa5
Compare
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
quick tests seems to work fine :)
|
Unfortunately this conflicts, most likely because of the rubix upgrade |
st3iny
force-pushed
the
reduce-log-messages-when-no-model
branch
from
8050aa5 to
cc20cf5
Compare
Signed-off-by: Victor Lap <[email protected]> Signed-off-by: Richard Steinmetz <[email protected]> Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
reduce-log-messages-when-no-model
branch
from
cc20cf5 to
8a1cb77
Compare
|
Fixed the outdated license header for the new class |
5 participants
This PR aims to fix #793.
I've separated the fact that a model could not be found from the other possible service exceptions. When such a case is found, it now only logs to the debug log. This might technically be duplicate, but I think it's good to include anyways for debugging purposes.