fix(LoginClassifier): Adjust log levels / reduce logging noise #875
Conversation
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
st3iny
left a comment
st3iny
left a comment
There was a problem hiding this comment.
To me this looks more like fighting the symptoms rather than fixing the actual issue.
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
AndyScherzinger
force-pushed
the
fix-logging-noise-reduction
branch
2 times, most recently
from
25c266f to
d631fae
Compare
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered. * Adjusts log levels (Warning -> a mixture of Debug and Info) of the two main messages that aren't rate limited * Adjusts log levels of the already rate limited messages to Info level (from Warning) to be more consistent with Brute Force Protection log levels This cuts down on the log noise from "Detected a login from a suspicious login..." All logs remain available at the appropriate log levels if desired. Signed-off-by: Josh <[email protected]>
ChristophWurst
force-pushed
the
fix-logging-noise-reduction
branch
from
d631fae to
6094ae6
Compare
While #152 addressed rate limiting notifications to users, we still have some logging outside of there that isn't covered.
This cuts down on the log noise from "Detected a login from a suspicious login..."
All logs remain available at the appropriate log levels if desired.
Fixes #303