Skip to content

fix(NegativeSampleGenerator): Prevent duplicate user IDs when getting unique IPs #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChristophWurst merged 4 commits into from
Jan 7, 2025
Merged

fix(NegativeSampleGenerator): Prevent duplicate user IDs when getting unique IPs #958

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1e2b79
fix(NegativeSampleGenerator): Prevent duplicate user IDs when getting…
DerDreschner Nov 25, 2024
cbe0fad
fix(NegativeSampleGenerator): Remove duplicate PHPDoc tag
DerDreschner Nov 25, 2024
2d89466
fix(NegativeSampleGenerator): Align operator in added unit test
DerDreschner Nov 25, 2024
d4c332d
fix(NegativeSampleGenerator): Align expected results in unit test
DerDreschner Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(NegativeSampleGenerator): Align operator in added unit test 
Signed-off-by: David Dreschner <[email protected]>
  • Loading branch information
@DerDreschner @ChristophWurst
DerDreschner authored and ChristophWurst committed Jan 7, 2025
commit 2d8946674356c992ec64b744f437faea461bb47b
3 changes: 2 additions & 1 deletion tests/Unit/Service/NegativeSampleGeneratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ public function testGenerateMultipleShuffledFromLimitedUnique(): void {
* DataSet can consist of multiple unique entries only. If not handled correctly,
* this will result in an array without any IP. This tests the
* correct handling. See GitHub issue #860 for more.
* @return void
*/
public function testGenerateMultipleShuffledFromUniquesOnly(): void {
$positives = new Unlabeled([
Expand All @@ -151,7 +152,7 @@ public function testGenerateMultipleShuffledFromUniquesOnly(): void {
$ipVec = array_slice($sample, 16, 32);

self::assertTrue(
$ipVec == self::decToBitArray(1, 32) ||
$ipVec === self::decToBitArray(1, 32) ||
$ipVec === self::decToBitArray(2, 32),
'Sample has an unique IP'
);
Expand Down