fix: try to avoid memory exhaustion #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
reviewed
Apr 16, 2025
| )); | ||
| )) | ||
| ->orderBy('last_seen', 'DESC') // Use most recent data in case of limiting | ||
| ->setMaxResults(3_000); // More data will like exhaust memory |
Member
Author
There was a problem hiding this comment.
I think they took inspiration from Rust :)
marcelklehr
reviewed
Apr 16, 2025
| if ($validationPositives->count() > self::MAX_SAMPLES_VALIDATE_POSITIVES) { | ||
| $threshold = (self::MAX_SAMPLES_VALIDATE_POSITIVES / $validationPositives->count()) * 100; | ||
| $validationPositives = $validationPositives->filter(fn () => random_int(0, 100) <= $threshold); | ||
| } |
marcelklehr
approved these changes
Apr 16, 2025
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/avoid-memory-exhaustion
branch
from
8882f76 to
8a7d3cc
Compare
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On medium and large installations there can be a lot of login data. Loading it can exhaust the available PHP memory.
This limits the impact in two steps
master: I was not able to run
occ suspiciouslogin:train --v6 --dry-run -vvvwith a memory limit of 512M (Nextcloud default)here: I can run
occ suspiciouslogin:train --v6 --dry-run -vvvsuccessfully with a memory limit of 256M