Skip to content

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 29, 2024

Some small fixes I had included in another branch but are easier to get in separately, mostly found in sentry as reported through the js console:

  • fix: Add aria-label to pagination
  • fix: Fix missing actions for empty default slot
  • fix: Proper evaluation order when building errors strings

@juliusknorr juliusknorr requested review from enjeck and grnd-alt August 29, 2024 11:00
@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Aug 29, 2024
@juliusknorr juliusknorr changed the title fix/small Fix console warnings and errors reported in sentry Aug 29, 2024
@juliusknorr juliusknorr changed the title Fix console warnings and errors reported in sentry Fix console warnings and errors Aug 29, 2024
Copy link
Contributor

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@juliusknorr juliusknorr merged commit ee0ffa4 into main Aug 30, 2024
@juliusknorr juliusknorr deleted the fix/small branch August 30, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants