Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 8, 2023

I find the current icon a bit out of our icon style.
Using material design icon, I suggest we use this :)

Before After
2023-08-08_15-36 2023-08-08_15-36_1

Quick PR, feel free to discard 😉

@skjnldsv skjnldsv added design Related to the design papercut Small issues that doesn't break the ux/ui 3. to review Waiting for reviews labels Aug 8, 2023
@skjnldsv skjnldsv self-assigned this Aug 8, 2023
@ChristophWurst

This comment was marked as off-topic.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that the current icon can use improvement – the suggestion looks a bit too much like a calculator though @skjnldsv?

What do you think about the Material Design "table" icon: https://pictogrammers.com/library/mdi/icon/table/
I would approve :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2023

What do you think about the Material Design "table" icon: pictogrammers.com/library/mdi/icon/table

I wanted to use that one, but it's not an official Google one, so I figured you would prefer a slightly different one from what Google offers 😉

Let's use the one you proposed! 🚀

Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv
Copy link
Member Author

skjnldsv commented Aug 8, 2023

Done! See updated first comment @jancborchardt

@skjnldsv skjnldsv requested a review from jancborchardt August 8, 2023 14:14
@datenangebot
Copy link
Collaborator

Please have in mind: The focus is not to handle tables and it's data, it will be more like a "no coding apps platform" one day. Automation, integration and different view modes (tiles, grid, blog, table, ...) will be in the focus. Maybe the icon can support this approach a bit more.

The proposed icon is not that bad, as it does not explicit look like an table, could also be a grid or tiles...
But it looks a bit like a window or a positioning indicator for windows on a desktop...
What about this one? https://pictogrammers.com/library/mdi/icon/apps-box/

SCR-20230808-rtns SCR-20230808-rtwc

@Hephi2 What do you think?

@juliusknorr
Copy link
Member

But it looks a bit like a window or a positioning indicator for windows on a desktop...

Which would somehow also fit the larger no code "app" picture. The apps box looks a bit too generic in my oppinion, the table one for me also brings some association with structured data, which I'd say is a better fit - and as you mentioned it could also be generic enough to be matching grid/tile layouts.

@datenangebot
Copy link
Collaborator

But it looks a bit like a window or a positioning indicator for windows on a desktop...

Which would somehow also fit the larger no code "app" picture. The apps box looks a bit too generic in my oppinion, the table one for me also brings some association with structured data, which I'd say is a better fit - and as you mentioned it could also be generic enough to be matching grid/tile layouts.

We already use that icon in a very present way, because it is included in any text editor all over nextcloud:
SCR-20230810-jpis

Thus I would tend to my suggestion...?

@skjnldsv
Copy link
Member Author

We already use that icon in a very present way, because it is included in any text editor all over nextcloud:

Which is fine as it is referring to... tables ;)

@juliusknorr
Copy link
Member

@datenangebot How about going with the tables one for now then? We can always reconsider others once the no-code platform roadmap has moved, but as the app is called tables and a table representation is the only display mode as of now this seems the best one for the time being.

@skjnldsv
Copy link
Member Author

Considering Julius and Jan's comments as approval. Le'ts go :)

@skjnldsv skjnldsv merged commit 79e7571 into main Aug 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the new/icon branch August 10, 2023 10:31
stefan-niedermann added a commit to stefan-niedermann/nextcloud-tables that referenced this pull request Aug 10, 2023
@jancborchardt
Copy link
Member

Yes, we can always adjust.
Further down the line, a new icon which reflects additional no-code capabilities can even go along with a "Tables 2"-like announcement which I’m sure @jospoortvliet would be happy about. :)

@datenangebot datenangebot restored the new/icon branch August 11, 2023 06:03
@datenangebot
Copy link
Collaborator

@skjnldsv Please stop merging things without my approval!
I don't think that if two people agree that is a consent.

Don't get me wrong, I agree to change the icon. But please lets have a discussion that includes all aspects.
Changing an Icon is a big thing. Icons work as an I catcher. Seeing that table icon from text lets you expect a quite normal table.

The tables app is intended to make something like a no-coding-platform for nextcloud based on tables. (At least that's what I discussed with Frank.)
So if the name "tables" is misleading here, lets have a discussion for a better naming in general here.

And the other think is that I like to have a feedback from marketing here. Changing an icon might have side effects. Adjusting many times the icon can't be a good idea. And there is no strategy for having a "tables-2" announcement so far.

@ChristophWurst ChristophWurst deleted the new/icon branch August 11, 2023 06:22
@ChristophWurst ChristophWurst restored the new/icon branch August 11, 2023 06:22
@ChristophWurst
Copy link
Member

(reflex)

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@skjnldsv skjnldsv deleted the new/icon branch August 23, 2023 06:08
@datenangebot datenangebot added discussion Being discussed and removed 3. to review Waiting for reviews labels Nov 11, 2023
@datenangebot
Copy link
Collaborator

datenangebot commented Nov 11, 2023

I try to summarize and add one new idea:

Icon Status Comment
SCR-20231111-msbe actual used does not fitting from a design perspective
SCR-20231111-mscq ⛔️ is used for "normal" tables all over the nextcloud system, eg in text editor
SCR-20231111-mshm ⛔️ used in appstore for "apps"
SCR-20231113-mddm 💡new idea maybe we can just adjust the actual one for a better fitting. Here slightly rounded corners. Open for more adjustment ideas!
SCR-20231113-mapx 💡new idea 2 https://pictogrammers.com/library/mdi/icon/table-large/

@nimishavijay @jancborchardt @juliushaertl What do you think about the new icon idea?

@datenangebot datenangebot added this to the Version 1 milestone Nov 11, 2023
@jancborchardt
Copy link
Member

@datenangebot I think "New idea 2" would fit the Nextcloud style best. :)

@mortee
Copy link

mortee commented Nov 15, 2023

Just my 2c, "new idea 2" seems the best to me. Apparently matches the style of the other icons, while also doesn't cause potential confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

design Related to the design discussion Being discussed feedback-requested papercut Small issues that doesn't break the ux/ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants