Skip to content

Conversation

@tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky [email protected]

@mahibi
Copy link
Collaborator

mahibi commented Mar 30, 2021

editing fields don't show up when clicking on "edit" if initially no field has any data

@mahibi
Copy link
Collaborator

mahibi commented Mar 30, 2021

  • enter edit mode
  • bring app to background / turn off display
  • open app again
    --> editing mode is active but button says "EDIT" instead of "SAVE"

@mahibi
Copy link
Collaborator

mahibi commented Mar 30, 2021

when some fields are filled but others are left blank it looks pretty random where they are placed in the overview view.

grafik

@mahibi
Copy link
Collaborator

mahibi commented Mar 30, 2021

i see no avatar (also not the generated one with letters) and have no ability to set any

@mahibi
Copy link
Collaborator

mahibi commented Mar 31, 2021

  • please describe changes in the changelog.md

@tobiasKaminsky
Copy link
Member Author

editing fields don't show up when clicking on "edit" if initially no field has any data

How did you managed to have this?
I cannot remove full name nor email, once it is set.

@tobiasKaminsky
Copy link
Member Author

editing fields don't show up when clicking on "edit" if initially no field has any data

How did you managed to have this?
I cannot remove full name nor email, once it is set.

New user it is…

@tobiasKaminsky
Copy link
Member Author

i see no avatar (also not the generated one with letters) and have no ability to set any

I guess that some server side PR is missing.

@tobiasKaminsky
Copy link
Member Author

❗ rebased ❗

@mahibi
Copy link
Collaborator

mahibi commented Apr 7, 2021

22 new FindBugs warnings? @tobiasKaminsky

@AndyScherzinger
Copy link
Member

❗ rebased ❗

  • plus added some improvements to the UI xml code

tobiasKaminsky and others added 7 commits April 8, 2021 09:43
(avoid the word "phonebook" because then people would expect that numbers are used in the nc contact app)

Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
Signed-off-by: tobiasKaminsky <[email protected]>
@AndyScherzinger
Copy link
Member

@tobiasKaminsky @mahibi latest commits optimize layouting (whitespaces and dark/light theming)

Signed-off-by: Andy Scherzinger <[email protected]>
@mahibi mahibi merged commit ab061d1 into master Apr 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the profile branch April 8, 2021 13:15
@mahibi
Copy link
Collaborator

mahibi commented Apr 8, 2021

/backport to v11.x

@backportbot-nextcloud
Copy link

The backport to v11.x failed. Please do this backport manually.

@nextcloud-android-bot
Copy link
Collaborator

Lint

TypeMasterPR
Warnings130130
Errors33

FindBugs (new)

Warning TypeNumber
Bad practice Warnings12
Correctness Warnings195
Experimental Warnings2
Internationalization Warnings8
Performance Warnings62
Security Warnings8
Dodgy code Warnings246
Total533

FindBugs (master)

Warning TypeNumber
Bad practice Warnings12
Correctness Warnings279
Experimental Warnings2
Internationalization Warnings8
Performance Warnings60
Security Warnings17
Dodgy code Warnings292
Total670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants