Skip to content

Show "contact-name" and "contact-photo" when applicable #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mahibi merged 3 commits into from
Jun 21, 2021
Merged

Show "contact-name" and "contact-photo" when applicable #1334

mahibi merged 3 commits into from
Jun 21, 2021

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Jun 17, 2021 •
edited by AndyScherzinger
Loading

@nickvergessen nickvergessen requested a review from mahibi June 17, 2021 12:27
@mahibi
Copy link
Collaborator

mahibi commented Jun 17, 2021 •
edited
Loading

didn't work for me yet.

  • downloaded a vcf from nextcloud addres book and pasted it in the chat.
  • created a contact in my phone with photo and shared contact to nextcloud talk app

no name or photo was shown..

from where and how did you share the vcf? @nickvergessen

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 17, 2021

Requires nextcloud/spreed#5731 to be merged first

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 17, 2021

Merged now

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Jun 17, 2021

@nickvergessen I can polish the UI, sure thing 👍

Within the PR in case I am quick enough or as a followup. So. If it is working fine for you, don't wait for me 😉

@AndyScherzinger AndyScherzinger force-pushed the bugfix/1135/use-the-contacts-photo-and-name branch from 55bfa5d to df6b098 Compare June 21, 2021 15:35
@github-actions
Copy link
Contributor

github-actions bot commented Jun 21, 2021

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1334-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Drone: update Lint results to reflect reduced error/warning count [sk…
f09bf93 
…ip ci]

Signed-off-by: drone <noreply@drone>
@nextcloud-android-bot
Copy link
Collaborator

nextcloud-android-bot commented Jun 21, 2021

Lint

TypemasterPR
Warnings275273
Errors33

SpotBugs (new)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 141
Experimental Warnings 2
Internationalization Warnings 9
Performance Warnings 41
Security Warnings 4
Dodgy code Warnings 231
Total 440

SpotBugs (master)

Warning Type Number
Bad practice Warnings 12
Correctness Warnings 140
Experimental Warnings 2
Internationalization Warnings 8
Performance Warnings 40
Security Warnings 4
Dodgy code Warnings 230
Total 436

SpotBugs increased!

@nickvergessen
Copy link
Member Author

nickvergessen commented Jun 21, 2021

✨ UI fix up as always @AndyScherzinger 😎

@mahibi mahibi merged commit 9f29d8c into master Jun 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix/1135/use-the-contacts-photo-and-name branch June 21, 2021 17:52
@AndyScherzinger AndyScherzinger added this to the v12.0.0 milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews enhancement New feature or request feature: chat 🗨️ feature: sharing 🤝

Projects

None yet

Milestone

v12.1.0

Development

Successfully merging this pull request may close these issues.

Make sharing vcard files display better

5 participants

@nickvergessen @mahibi @AndyScherzinger @nextcloud-android-bot