Image keyboard support in chat #1749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starypatyk
added
3. to review
Receive images (usually GIFs) from keyboard and upload them to the current chat. Signed-off-by: Dariusz Olszewski <[email protected]>
Signed-off-by: Dariusz Olszewski <[email protected]>
mahibi
force-pushed
the
feature/411/gif_keyboard
branch
from
306e640 to
996c4c5
Compare
mahibi
approved these changes
Jan 4, 2022
Collaborator
|
works fine, thank you very much @starypatyk 👍 |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/1749-talk.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should resolve #411
Added support for images received from keyboard as described here:
https://developer.android.com/guide/topics/text/image-keyboard
When a keyboard (like Google Keyboard) sends an image - usually a GIF 😜 - to the text entry field, the code uploads the image to the current chat.
Implementation is a bit tricky, since it "injects" a new class ImageEmojiEditText into a part of the layout managed by external ChatKit component. However since the ImageEmojiEditText inherits from EmojiEditText used originally, ChatKit seems to work just fine. And we can attach the required callback in the ChatController class.