Fix loosing authentication on notify_push on any ws error #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #75 Signed-off-by: Grigorii Shartsev <[email protected]>
ShGKme
commented
Mar 22, 2023
Comment on lines
163
to
167
| setTimeout(() => { | ||
| if (window._notify_push_online) { | ||
| setupSocket() | ||
| setupSocket({ credentials }) | ||
| } | ||
| }, 1000 * window._notify_push_error_count) |
Contributor
Author
There was a problem hiding this comment.
There credentials were missed
Contributor
Author
|
Although it seems like this problem cause the issue, it is not clear to me, what was the reason for the first WS error started infinity errors loop. |
delete-merged-branch
bot
deleted the
fix/75/auth-on-error-in-notify-push
branch
ShGKme
added a commit
that referenced
this pull request
Mar 24, 2023
Fixes: - Fix zoom without SHIFT and by mouse wheel (#77) - Fix wrong display name in calls and temp messages (#72) - Fix loosing authentication on notify_push on any ws error caused brute force protection (#76) Signed-off-by: Grigorii Shartsev <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🚧 Tasks