Skip to content

WebRTC fixes and refactoring #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Ivansss merged 9 commits into from
Feb 18, 2022
Merged

WebRTC fixes and refactoring #731

Ivansss merged 9 commits into from
Feb 18, 2022

Conversation

@Ivansss
Copy link
Member

@Ivansss Ivansss commented Feb 17, 2022 •
edited
Loading

  • Fixed check to create answers. This will allow renegotation.
  • Code refactoring and clean up

@Ivansss
Fix check to create an answer when setting a remote description.
4acf55b 
We will create an answer if we just set the remote description of an offer.

Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Use peerConnectionDidCreateSessionDescription to set the local sessio…
c5130eb 
…n description and send it.

Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Remove duplicated code.
465ed5d 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Rename publisher peer related code.
e450c05 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Rename peerConnectionDidCreateSessionDescription to peerConnectionDid…
bbd786a 
…CreateLocalSessionDescription.

Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Rename description variable.
c17c795 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Send correct sdp to peerConnectionDidSetRemoteSessionDescription.
73306b9 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Use non deprecated functions to add candidates.
55c0ed3 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss
Remove unused code.
6e2d477 
Signed-off-by: Ivan Sein <[email protected]>
@Ivansss Ivansss changed the title WebRTC fixes WebRTC fixes and refactoring Feb 18, 2022
@Ivansss Ivansss marked this pull request as ready for review February 18, 2022 11:10
@Ivansss Ivansss merged commit 4fd6461 into master Feb 18, 2022
@Ivansss Ivansss deleted the webrtc-fixes branch February 18, 2022 11:11
@danxuliu danxuliu mentioned this pull request Feb 21, 2022
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ivansss