Skip to content

Conversation

@raimund-schluessler
Copy link
Member

This PR moves the app to npm v7 and simplifies the overall configuration. See nextcloud/app-tutorial#319.

@raimund-schluessler raimund-schluessler added Cleanup 3 - to review dependencies Pull requests that update a dependency file labels Jun 11, 2021
@raimund-schluessler raimund-schluessler added this to the 0.14.0 milestone Jun 11, 2021
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #1638 (3469c64) into master (af79de9) will increase coverage by 0.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1638      +/-   ##
============================================
+ Coverage     32.43%   32.72%   +0.29%     
  Complexity       25       25              
============================================
  Files            55       55              
  Lines          2806     2778      -28     
  Branches        533      535       +2     
============================================
- Hits            910      909       -1     
+ Misses         1896     1869      -27     

@raimund-schluessler raimund-schluessler merged commit 53a27c7 into master Jun 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/npm7-config branch June 11, 2021 21:31
@skjnldsv
Copy link
Member

We didn't really agreed to move to :p
That's why there was this pr nextcloud/app-tutorial#319 and we asked on the frontend channel 😁

So far it seems to work, but I don't know about others apps/libs 🙈

@raimund-schluessler
Copy link
Member Author

We didn't really agreed to move to :p

Hm, seems I was a bit to fast with that one. 🙈 But since it works quite well, I don't really want to go back. And someone has to do the first step 😄

@skjnldsv
Copy link
Member

The issue is that either everyone move to that or no one. Switching versions back and forth is not acceptable :(
So if some apps breaks, we're kind of blocked :'(

"@nextcloud/eslint-plugin": "^2.0.0",
"@nextcloud/stylelint-config": "^1.0.0-beta.0",
"@nextcloud/webpack-vue-config": "^4.0.3",
"babel-core": "^7.0.0-bridge.0",
Copy link
Member

@skjnldsv skjnldsv Jun 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be needed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, for jest?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is for jest. Although I didn't test it without.

"devDependencies": {
"@babel/core": "^7.14.5",
"@babel/eslint-parser": "7.14.5",
"@babel/plugin-proposal-object-rest-spread": "^7.14.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already within @babel/preset-env

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raimund-schluessler
Copy link
Member Author

The issue is that either everyone move to that or no one. Switching versions back and forth is not acceptable :(
So if some apps breaks, we're kind of blocked :'(

Yes, I know. But I guess, we will only know if something breaks if everyone gives it a try. I am fine to move back to npm6 as an interim solution in case something really breaks. However, we won't be able to stay with npm6 forever anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants