-
Notifications
You must be signed in to change notification settings - Fork 106
Use npm v7 and simplify overall configuration #1638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Raimund Schlüßler <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
============================================
+ Coverage 32.43% 32.72% +0.29%
Complexity 25 25
============================================
Files 55 55
Lines 2806 2778 -28
Branches 533 535 +2
============================================
- Hits 910 909 -1
+ Misses 1896 1869 -27 |
|
We didn't really agreed to move to :p So far it seems to work, but I don't know about others apps/libs 🙈 |
Hm, seems I was a bit to fast with that one. 🙈 But since it works quite well, I don't really want to go back. And someone has to do the first step 😄 |
|
The issue is that either everyone move to that or no one. Switching versions back and forth is not acceptable :( |
| "@nextcloud/eslint-plugin": "^2.0.0", | ||
| "@nextcloud/stylelint-config": "^1.0.0-beta.0", | ||
| "@nextcloud/webpack-vue-config": "^4.0.3", | ||
| "babel-core": "^7.0.0-bridge.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be needed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, for jest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for jest. Although I didn't test it without.
| "devDependencies": { | ||
| "@babel/core": "^7.14.5", | ||
| "@babel/eslint-parser": "7.14.5", | ||
| "@babel/plugin-proposal-object-rest-spread": "^7.14.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already within @babel/preset-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I know. But I guess, we will only know if something breaks if everyone gives it a try. I am fine to move back to npm6 as an interim solution in case something really breaks. However, we won't be able to stay with npm6 forever anyway. |
This PR moves the app to npm v7 and simplifies the overall configuration. See nextcloud/app-tutorial#319.