Allow sharing with circles #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #995 +/- ##
==========================================
- Coverage 24.88% 24.58% -0.31%
==========================================
Files 48 48
Lines 2479 2510 +31
Branches 471 480 +9
==========================================
Hits 617 617
- Misses 1722 1752 +30
- Partials 140 141 +1 |
georgehrke
approved these changes
Apr 30, 2020
skjnldsv
reviewed
Apr 30, 2020
Comment on lines
+221
to
+233
| if (results.data.ocs.meta.status === 'failure') { | ||
| return [] | ||
| } | ||
| let circles = [] | ||
| if (Array.isArray(results.data.ocs.data.circles)) { | ||
| circles = circles.concat(results.data.ocs.data.circles) | ||
| } | ||
| if (Array.isArray(results.data.ocs.data.exact.circles)) { | ||
| circles = circles.concat(results.data.ocs.data.exact.circles) | ||
| } | ||
| if (circles.length === 0) { | ||
| return [] | ||
| } |
Member
There was a problem hiding this comment.
We really need an api for this....
Member
Author
There was a problem hiding this comment.
Hm, it's a bit messy and also leads to errors, see nextcloud/calendar#2220.
But that's how it is for now.
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feature/169/circles
branch
from
ead9057 to
fd1e90a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements sharing with a circle.
Closes #169.