-
Notifications
You must be signed in to change notification settings - Fork 116
Comparing changes
Open a pull request
base repository: nextcloud/text
base: 111c5d1
head repository: nextcloud/text
compare: 1911a14
- 16 commits
- 11 files changed
- 4 contributors
Commits on Dec 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b09420 - Browse repository at this point
Copy the full SHA 8b09420View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a607a0 - Browse repository at this point
Copy the full SHA 4a607a0View commit details
Commits on Dec 17, 2023
-
chore(dev-deps): Bump nextcloud/ocp package
Signed-off-by: GitHub <noreply@github.com>
Configuration menu - View commit details
-
Copy full SHA for 8768003 - Browse repository at this point
Copy the full SHA 8768003View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed82004 - Browse repository at this point
Copy the full SHA ed82004View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a239f8 - Browse repository at this point
Copy the full SHA 8a239f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 020a280 - Browse repository at this point
Copy the full SHA 020a280View commit details -
test(cy): ensure default language in workspace spec
Some tests modify it - so set it to `en` in `beforeEach`. Following the recommendataion of preparing everything in `beforeEach` hooks rather then reverting the changes in `after` hooks so the state of failing tests can be inspected. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for 0c7a0e3 - Browse repository at this point
Copy the full SHA 0c7a0e3View commit details -
test(cy): use
createTestFolder()and `visitTestFolder()* `cy.openWorkspace()` and `cy.createDescription()` use the currently opened path now. They don't need any argument anymore. This also avoids duplicate page loads. * Use 'testFolder' alias and `this.testFolder` instead of `currentFolder` variable. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for b63c004 - Browse repository at this point
Copy the full SHA b63c004View commit details
Commits on Dec 18, 2023
-
test(cy): use function() instead of arrow shorthand
Otherwise `this.testFolder` is not available as `this` cannot be reassigned with arrow functions. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for 7842447 - Browse repository at this point
Copy the full SHA 7842447View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad331b6 - Browse repository at this point
Copy the full SHA ad331b6View commit details -
test(cy): skip test failing due to server issue
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for 77d7756 - Browse repository at this point
Copy the full SHA 77d7756View commit details -
Merge pull request #5142 from nextcloud/test/fix-cypress
test(cy): skip test failing due to server issue
Configuration menu - View commit details
-
Copy full SHA for c32d36a - Browse repository at this point
Copy the full SHA c32d36aView commit details -
fix(sync): preserve queue if sendRemainingSteps fails
During a network disconnect Yjs-websocket notices missing awareness messages and closes the connection. In this case the remaining steps can also not be send out and the request fails. Preserve the queue so we can use it once the network is back up. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for fdd77ef - Browse repository at this point
Copy the full SHA fdd77efView commit details -
fix(sync): keep queue around during reconnects
When yjs does not receive awareness updates it will close and reopen the websocket. Keep the content of the queue, i.e. the outgoing steps so they can be send out once the connection is back. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for e757c16 - Browse repository at this point
Copy the full SHA e757c16View commit details -
fix(sync): ensure queue stays the same array
Change the content of `queue` with `queue.splice` rather than setting `queue` to another array. Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for d9faf1c - Browse repository at this point
Copy the full SHA d9faf1cView commit details -
fix(sync): only clear queue after successful send
Also add a unit test for the websocket polyfill Signed-off-by: Max <max@nextcloud.com>
Configuration menu - View commit details
-
Copy full SHA for 1911a14 - Browse repository at this point
Copy the full SHA 1911a14View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 111c5d1...1911a14