Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 111c5d1
Choose a base ref
...
head repository: nextcloud/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1911a14
Choose a head ref
  • 16 commits
  • 11 files changed
  • 4 contributors

Commits on Dec 16, 2023

  1. Configuration menu
    Copy the full SHA
    8b09420 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a607a0 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2023

  1. chore(dev-deps): Bump nextcloud/ocp package

    Signed-off-by: GitHub <noreply@github.com>
    nextcloud-command authored Dec 17, 2023
    Configuration menu
    Copy the full SHA
    8768003 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ed82004 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8a239f8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    020a280 View commit details
    Browse the repository at this point in the history
  5. test(cy): ensure default language in workspace spec

    Some tests modify it - so set it to `en` in `beforeEach`.
    
    Following the recommendataion of preparing everything
    in `beforeEach` hooks
    rather then reverting the changes in `after` hooks
    so the state of failing tests can be inspected.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    0c7a0e3 View commit details
    Browse the repository at this point in the history
  6. test(cy): use createTestFolder() and `visitTestFolder()

    * `cy.openWorkspace()` and `cy.createDescription()`
      use the currently opened path now.
      They don't need any argument anymore.
      This also avoids duplicate page loads.
    * Use 'testFolder' alias and `this.testFolder`
      instead of `currentFolder` variable.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 17, 2023
    Configuration menu
    Copy the full SHA
    b63c004 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. test(cy): use function() instead of arrow shorthand

    Otherwise `this.testFolder` is not available
    as `this` cannot be reassigned with arrow functions.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    7842447 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ad331b6 View commit details
    Browse the repository at this point in the history
  3. test(cy): skip test failing due to server issue

    nextcloud/server#42306
    causes the DELETE request to fail with 423 Locked.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud authored and juliusknorr committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    77d7756 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #5142 from nextcloud/test/fix-cypress

    test(cy): skip test failing due to server issue
    max-nextcloud authored Dec 18, 2023
    Configuration menu
    Copy the full SHA
    c32d36a View commit details
    Browse the repository at this point in the history
  5. fix(sync): preserve queue if sendRemainingSteps fails

    During a network disconnect
    Yjs-websocket notices missing awareness messages and closes the connection.
    In this case the remaining steps can also not be send out and the request fails.
    Preserve the queue so we can use it once the network is back up.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    fdd77ef View commit details
    Browse the repository at this point in the history
  6. fix(sync): keep queue around during reconnects

    When yjs does not receive awareness updates
    it will close and reopen the websocket.
    Keep the content of the queue, i.e. the outgoing steps
    so they can be send out once the connection is back.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e757c16 View commit details
    Browse the repository at this point in the history
  7. fix(sync): ensure queue stays the same array

    Change the content of `queue` with `queue.splice`
    rather than setting `queue` to another array.
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d9faf1c View commit details
    Browse the repository at this point in the history
  8. fix(sync): only clear queue after successful send

    Also add a unit test for the websocket polyfill
    
    Signed-off-by: Max <max@nextcloud.com>
    max-nextcloud committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1911a14 View commit details
    Browse the repository at this point in the history
Loading