Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud/text
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: a2ba0cd
Choose a base ref
...
head repository: nextcloud/text
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a2b5ef2
Choose a head ref
  • 5 commits
  • 8 files changed
  • 1 contributor

Commits on Jul 3, 2024

  1. refactor: hide connection in sync service 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    299c8e8 View commit details
    Browse the repository at this point in the history

  2. test(cy): wait longer for initial sync to avoid timeouts 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3f58bab View commit details
    Browse the repository at this point in the history

  3. test(cy): also test failed reconnect attempt 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    e993f5f View commit details
    Browse the repository at this point in the history

  4. fix(Editor): separate close and disconnect functions 

    * `close` is for closing the editor.
  It tries to save the document and clean everything up.
* `disconnect` is for cleaning up the current collaboration sessions.
  It will not save the document and asumes the editing will be resumed
  after a reconnect.

Move `sendRemainingSteps` out to the sync service.
Also make close in the websocket polyfill sync.
Just clean up the polyfills state.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    2c03655 View commit details
    Browse the repository at this point in the history

  5. refactor(yjs): move queue handling into helper 

    Signed-off-by: Max <max@nextcloud.com>

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    a2b5ef2 View commit details
    Browse the repository at this point in the history
Loading